summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authordejun.xdj <dejun.xdj@alibaba-inc.com>2018-07-30 21:33:01 +0800
committerdejun.xdj <dejun.xdj@alibaba-inc.com>2018-07-30 21:33:01 +0800
commit6491717c88143507567420398131eaa8933f3ec9 (patch)
treec723b5380103a6dd996df42a2cbca0b4fb3535c9 /src
parentd6f5ec6f098f7f6b741bc3face1608c25b233caa (diff)
downloadredis-6491717c88143507567420398131eaa8933f3ec9.tar.gz
Streams: rearrange the usage of '-' and '+' IDs in stream commands.
Diffstat (limited to 'src')
-rw-r--r--src/t_stream.c26
1 files changed, 13 insertions, 13 deletions
diff --git a/src/t_stream.c b/src/t_stream.c
index 8725542c9..f233785ae 100644
--- a/src/t_stream.c
+++ b/src/t_stream.c
@@ -1137,7 +1137,7 @@ void xaddCommand(client *c) {
maxlen_arg_idx = i;
} else {
/* If we are here is a syntax error or a valid ID. */
- if (streamParseIDOrReply(c,c->argv[i],&id,0) != C_OK) return;
+ if (streamParseIDOrReply(c,c->argv[i],&id,0,0) != C_OK) return;
id_given = 1;
break;
}
@@ -1206,8 +1206,8 @@ void xrangeGenericCommand(client *c, int rev) {
robj *startarg = rev ? c->argv[3] : c->argv[2];
robj *endarg = rev ? c->argv[2] : c->argv[3];
- if (streamParseIDOrReply(c,startarg,&startid,0) == C_ERR) return;
- if (streamParseIDOrReply(c,endarg,&endid,UINT64_MAX) == C_ERR) return;
+ if (streamParseIDOrReply(c,startarg,&startid,0,1) == C_ERR) return;
+ if (streamParseIDOrReply(c,endarg,&endid,UINT64_MAX,1) == C_ERR) return;
/* Parse the COUNT option if any. */
if (c->argc > 4) {
@@ -1393,7 +1393,7 @@ void xreadCommand(client *c) {
ids[id_idx].seq = UINT64_MAX;
continue;
}
- if (streamParseIDOrReply(c,c->argv[i],ids+id_idx,0) != C_OK)
+ if (streamParseIDOrReply(c,c->argv[i],ids+id_idx,0,0) != C_OK)
goto cleanup;
}
@@ -1667,7 +1667,7 @@ NULL
streamID id;
if (!strcmp(c->argv[4]->ptr,"$")) {
id = s->last_id;
- } else if (streamParseIDOrReply(c,c->argv[4],&id,0) != C_OK) {
+ } else if (streamParseIDOrReply(c,c->argv[4],&id,0,0) != C_OK) {
return;
}
streamCG *cg = streamCreateCG(s,grpname,sdslen(grpname),&id);
@@ -1684,7 +1684,7 @@ NULL
streamID id;
if (!strcmp(c->argv[4]->ptr,"$")) {
id = s->last_id;
- } else if (streamParseIDOrReply(c,c->argv[4],&id,0) != C_OK) {
+ } else if (streamParseIDOrReply(c,c->argv[4],&id,0,1) != C_OK) {
return;
}
cg->last_id = id;
@@ -1744,7 +1744,7 @@ void xackCommand(client *c) {
for (int j = 3; j < c->argc; j++) {
streamID id;
unsigned char buf[sizeof(streamID)];
- if (streamParseIDOrReply(c,c->argv[j],&id,0) != C_OK) return;
+ if (streamParseIDOrReply(c,c->argv[j],&id,0,0) != C_OK) return;
streamEncodeID(buf,&id);
/* Lookup the ID in the group PEL: it will have a reference to the
@@ -1791,9 +1791,9 @@ void xpendingCommand(client *c) {
if (c->argc >= 6) {
if (getLongLongFromObjectOrReply(c,c->argv[5],&count,NULL) == C_ERR)
return;
- if (streamParseIDOrReply(c,c->argv[3],&startid,0) == C_ERR)
+ if (streamParseIDOrReply(c,c->argv[3],&startid,0,1) == C_ERR)
return;
- if (streamParseIDOrReply(c,c->argv[4],&endid,UINT64_MAX) == C_ERR)
+ if (streamParseIDOrReply(c,c->argv[4],&endid,UINT64_MAX,1) == C_ERR)
return;
}
@@ -2002,7 +2002,7 @@ void xclaimCommand(client *c) {
int j;
for (j = 4; j < c->argc; j++) {
streamID id;
- if (streamParseIDOrReply(NULL,c->argv[j],&id,0) != C_OK) break;
+ if (streamParseIDOrReply(NULL,c->argv[j],&id,0,0) != C_OK) break;
}
int last_id_arg = j-1; /* Next time we iterate the IDs we now the range. */
@@ -2061,7 +2061,7 @@ void xclaimCommand(client *c) {
for (int j = 5; j <= last_id_arg; j++) {
streamID id;
unsigned char buf[sizeof(streamID)];
- if (streamParseIDOrReply(c,c->argv[j],&id,0) != C_OK) return;
+ if (streamParseIDOrReply(c,c->argv[j],&id,0,0) != C_OK) return;
streamEncodeID(buf,&id);
/* Lookup the ID in the group PEL. */
@@ -2144,13 +2144,13 @@ void xdelCommand(client *c) {
* executed because at some point an invalid ID is parsed. */
streamID id;
for (int j = 2; j < c->argc; j++) {
- if (streamParseIDOrReply(c,c->argv[j],&id,0) != C_OK) return;
+ if (streamParseIDOrReply(c,c->argv[j],&id,0,0) != C_OK) return;
}
/* Actually apply the command. */
int deleted = 0;
for (int j = 2; j < c->argc; j++) {
- streamParseIDOrReply(c,c->argv[j],&id,0); /* Retval already checked. */
+ streamParseIDOrReply(c,c->argv[j],&id,0,0); /* Retval already checked. */
deleted += streamDeleteItem(s,&id);
}