summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorguybe7 <guy.benoish@redislabs.com>2023-04-20 22:28:44 +0200
committerGitHub <noreply@github.com>2023-04-20 23:28:44 +0300
commitf809e10fd8f9e210291d05e80f6d08e3ddc01ae7 (patch)
treeed0ffbfa5b6772013e58640b7a71b8742c7899c0 /src
parent2f46e96d44341669df0c9872b8082fccfed148d3 (diff)
downloadredis-f809e10fd8f9e210291d05e80f6d08e3ddc01ae7.tar.gz
Minor change around the req-res validator, skip sentinel commands (#12083)
1. Check for missing schema only after the docs contain sentinel commands 2. The ignore-list in the C file contain only commands that cannot have a reply schema. The one in the py file is an extension of that list 3. Temp: skipsentinel commands don't have a schema or test coverage yet, add them to the py list Solve CI error introduced by #12018
Diffstat (limited to 'src')
-rw-r--r--src/logreqres.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/logreqres.c b/src/logreqres.c
index aa54b721d..6e7621d35 100644
--- a/src/logreqres.c
+++ b/src/logreqres.c
@@ -186,7 +186,8 @@ size_t reqresAppendRequest(client *c) {
/* Ignore commands that have streaming non-standard response */
sds cmd = argv[0]->ptr;
- if (!strcasecmp(cmd,"sync") ||
+ if (!strcasecmp(cmd,"debug") || /* because of DEBUG SEGFAULT */
+ !strcasecmp(cmd,"sync") ||
!strcasecmp(cmd,"psync") ||
!strcasecmp(cmd,"monitor") ||
!strcasecmp(cmd,"subscribe") ||
@@ -194,11 +195,7 @@ size_t reqresAppendRequest(client *c) {
!strcasecmp(cmd,"ssubscribe") ||
!strcasecmp(cmd,"sunsubscribe") ||
!strcasecmp(cmd,"psubscribe") ||
- !strcasecmp(cmd,"punsubscribe") ||
- !strcasecmp(cmd,"debug") ||
- !strcasecmp(cmd,"pfdebug") ||
- !strcasecmp(cmd,"lolwut") ||
- (!strcasecmp(cmd,"sentinel") && argc > 1 && !strcasecmp(argv[1]->ptr,"debug")))
+ !strcasecmp(cmd,"punsubscribe"))
{
return 0;
}