diff options
| author | Binbin <binloveplay1314@qq.com> | 2022-11-22 22:38:27 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-11-22 16:38:27 +0200 |
| commit | 543e0daa6302f87478c660d2b96b2151afbf2c6a (patch) | |
| tree | 6bf3094177fdeb0320e29a042593d5fbf0fc04d1 /tests/README.md | |
| parent | 6e9724cb6a8ff2bad4c8aeb591ee0d14120ca7af (diff) | |
| download | redis-543e0daa6302f87478c660d2b96b2151afbf2c6a.tar.gz | |
Make assert_refcount skip the OBJECT REFCOUNT check with needs:debug tag (#11487)
This PR add `assert_refcount_morethan`, and modify `assert_refcount` to skip
the `OBJECT REFCOUNT` check with `needs:debug` flag. Use them to modify all
`OBJECT REFCOUNT` calls and also update the tests/README to be more specific.
The reasoning is that some of these tests could be testing something important,
and along the way also add a check for the refcount, and it could be a shame to skip
the whole test just because the refcount functionality is missing or blocked.
but much like the fact that some redis variants may not support DEBUG,
and still we want to run the majority of the test for coverage, and just skip the digest match.
Diffstat (limited to 'tests/README.md')
| -rw-r--r-- | tests/README.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/README.md b/tests/README.md index 4b2251bc5..1aa98dc9f 100644 --- a/tests/README.md +++ b/tests/README.md @@ -40,12 +40,12 @@ The following compatibility and capability tags are currently used: | `large-memory` | Test that requires more than 100mb | | `tls:skip` | Not compatible with `--tls`. | | `needs:repl` | Uses replication and needs to be able to `SYNC` from server. | -| `needs:debug` | Uses the `DEBUG` command or other debugging focused commands (like `OBJECT`). | +| `needs:debug` | Uses the `DEBUG` command or other debugging focused commands (like `OBJECT REFCOUNT`). | | `needs:pfdebug` | Uses the `PFDEBUG` command. | | `needs:config-maxmemory` | Uses `CONFIG SET` to manipulate memory limit, eviction policies, etc. | | `needs:config-resetstat` | Uses `CONFIG RESETSTAT` to reset statistics. | | `needs:reset` | Uses `RESET` to reset client connections. | -| `needs:save` | Uses `SAVE` to create an RDB file. | +| `needs:save` | Uses `SAVE` or `BGSAVE` to create an RDB file. | When using an external server (`--host` and `--port`), filtering using the `external:skip` tags is done automatically. |