diff options
author | perryitay <85821686+perryitay@users.noreply.github.com> | 2021-11-03 20:47:18 +0200 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-11-03 20:47:18 +0200 |
commit | f27083a4a8a6682e391a533724c904c69852c0a0 (patch) | |
tree | 74a12c1cbb3f7885ef5275a96227b12925efc114 /tests/integration/corrupt-dump.tcl | |
parent | f11a2d4dd764c996b2d0c0cb5abde13f2445b40c (diff) | |
download | redis-f27083a4a8a6682e391a533724c904c69852c0a0.tar.gz |
Add support for list type to store elements larger than 4GB (#9357)
Redis lists are stored in quicklist, which is currently a linked list of ziplists.
Ziplists are limited to storing elements no larger than 4GB, so when bigger
items are added they're getting truncated.
This PR changes quicklists so that they're capable of storing large items
in quicklist nodes that are plain string buffers rather than ziplist.
As part of the PR there were few other changes in redis:
1. new DEBUG sub-commands:
- QUICKLIST-PACKED-THRESHOLD - set the threshold of for the node type to
be plan or ziplist. default (1GB)
- QUICKLIST <key> - Shows low level info about the quicklist encoding of <key>
2. rdb format change:
- A new type was added - RDB_TYPE_LIST_QUICKLIST_2 .
- container type (packed / plain) was added to the beginning of the rdb object
(before the actual node list).
3. testing:
- Tests that requires over 100MB will be by default skipped. a new flag was
added to 'runtest' to run the large memory tests (not used by default)
Co-authored-by: sundb <sundbcn@gmail.com>
Co-authored-by: Oran Agra <oran@redislabs.com>
Diffstat (limited to 'tests/integration/corrupt-dump.tcl')
-rw-r--r-- | tests/integration/corrupt-dump.tcl | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/tests/integration/corrupt-dump.tcl b/tests/integration/corrupt-dump.tcl index c91027531..cc811a668 100644 --- a/tests/integration/corrupt-dump.tcl +++ b/tests/integration/corrupt-dump.tcl @@ -135,6 +135,14 @@ test {corrupt payload: quicklist with empty ziplist} { } } +test {corrupt payload: quicklist encoded_len is 0} { + start_server [list overrides [list loglevel verbose use-exit-on-panic yes crash-memcheck-enabled no] ] { + catch { r restore _list 0 "\x12\x01\x01\x00\n\x00\x8f\xc6\xc0W\x1c\n\xb3<" replace } err + assert_match "*Bad data format*" $err + r ping + } +} + test {corrupt payload: #3080 - ziplist} { start_server [list overrides [list loglevel verbose use-exit-on-panic yes crash-memcheck-enabled no] ] { # shallow sanitization is enough for restore to safely reject the payload with wrong size |