diff options
author | Yossi Gottlieb <yossigo@gmail.com> | 2021-06-09 15:13:24 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-06-09 15:13:24 +0300 |
commit | 8a86bca5ed09094b561284fcb5b1fc416a4016dc (patch) | |
tree | 1507189b397646325d7270fd522c622f635e73ce /tests/integration/psync2-pingoff.tcl | |
parent | c396fd91a039feb5114e79f6f91459a0b1f74346 (diff) | |
download | redis-8a86bca5ed09094b561284fcb5b1fc416a4016dc.tar.gz |
Improve test suite to handle external servers better. (#9033)
This commit revives the improves the ability to run the test suite against
external servers, instead of launching and managing `redis-server` processes as
part of the test fixture.
This capability existed in the past, using the `--host` and `--port` options.
However, it was quite limited and mostly useful when running a specific tests.
Attempting to run larger chunks of the test suite experienced many issues:
* Many tests depend on being able to start and control `redis-server` themselves,
and there's no clear distinction between external server compatible and other
tests.
* Cluster mode is not supported (resulting with `CROSSSLOT` errors).
This PR cleans up many things and makes it possible to run the entire test suite
against an external server. It also provides more fine grained controls to
handle cases where the external server supports a subset of the Redis commands,
limited number of databases, cluster mode, etc.
The tests directory now contains a `README.md` file that describes how this
works.
This commit also includes additional cleanups and fixes:
* Tests can now be tagged.
* Tag-based selection is now unified across `start_server`, `tags` and `test`.
* More information is provided about skipped or ignored tests.
* Repeated patterns in tests have been extracted to common procedures, both at a
global level and on a per-test file basis.
* Cleaned up some cases where test setup was based on a previous test executing
(a major anti-pattern that repeats itself in many places).
* Cleaned up some cases where test teardown was not part of a test (in the
future we should have dedicated teardown code that executes even when tests
fail).
* Fixed some tests that were flaky running on external servers.
Diffstat (limited to 'tests/integration/psync2-pingoff.tcl')
-rw-r--r-- | tests/integration/psync2-pingoff.tcl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/integration/psync2-pingoff.tcl b/tests/integration/psync2-pingoff.tcl index 7744010a4..2864ba5af 100644 --- a/tests/integration/psync2-pingoff.tcl +++ b/tests/integration/psync2-pingoff.tcl @@ -5,7 +5,7 @@ # We keep these tests just because they reproduce edge cases in the replication # logic in hope they'll be able to spot some problem in the future. -start_server {tags {"psync2"}} { +start_server {tags {"psync2 external:skip"}} { start_server {} { # Config set debug_msg 0 ; # Enable additional debug messages @@ -74,7 +74,7 @@ start_server {} { }} -start_server {tags {"psync2"}} { +start_server {tags {"psync2 external:skip"}} { start_server {} { start_server {} { start_server {} { @@ -180,7 +180,7 @@ start_server {} { } }}}}} -start_server {tags {"psync2"}} { +start_server {tags {"psync2 external:skip"}} { start_server {} { start_server {} { |