diff options
author | Oran Agra <oran@redislabs.com> | 2023-04-12 09:19:21 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-12 09:19:21 +0300 |
commit | 997fa41e99271cc5c3a79e9bf8a1332b3d9ab0c2 (patch) | |
tree | e9518b5a84c42b73ba39b735bc4d11010adc3d70 /tests/sentinel | |
parent | 45b8eea19f3e2491dec669f0745e513a4c9d7329 (diff) | |
download | redis-997fa41e99271cc5c3a79e9bf8a1332b3d9ab0c2.tar.gz |
Attempt to solve MacOS CI issues in GH Actions (#12013)
The MacOS CI in github actions often hangs without any logs. GH argues that
it's due to resource utilization, either running out of disk space, memory, or CPU
starvation, and thus the runner is terminated.
This PR contains multiple attempts to resolve this:
1. introducing pause_process instead of SIGSTOP, which waits for the process
to stop before resuming the test, possibly resolving race conditions in some tests,
this was a suspect since there was one test that could result in an infinite loop in that
case, in practice this didn't help, but still a good idea to keep.
2. disable the `save` config in many tests that don't need it, specifically ones that use
heavy writes and could create large files.
3. change the `populate` proc to use short pipeline rather than an infinite one.
4. use `--clients 1` in the macos CI so that we don't risk running multiple resource
demanding tests in parallel.
5. enable `--verbose` to be repeated to elevate verbosity and print more info to stdout
when a test or a server starts.
Diffstat (limited to 'tests/sentinel')
-rw-r--r-- | tests/sentinel/tests/07-down-conditions.tcl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/sentinel/tests/07-down-conditions.tcl b/tests/sentinel/tests/07-down-conditions.tcl index 403f81e73..dabbc14c5 100644 --- a/tests/sentinel/tests/07-down-conditions.tcl +++ b/tests/sentinel/tests/07-down-conditions.tcl @@ -49,9 +49,9 @@ test "SDOWN is triggered by non-responding but not crashed instance" { set master_id [get_instance_id_by_port redis [lindex $master_addr 1]] set pid [get_instance_attrib redis $master_id pid] - exec kill -SIGSTOP $pid + pause_process $pid ensure_master_down - exec kill -SIGCONT $pid + resume_process $pid ensure_master_up } |