diff options
| author | Oran Agra <oran@redislabs.com> | 2021-04-18 11:55:54 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-04-18 11:55:54 +0300 |
| commit | f4b5a4d8698cfee563ee0c054bd97ef5b46c5d26 (patch) | |
| tree | a1d4c4c113834f6bbd2a10422050a52f19feadd6 /tests/support/util.tcl | |
| parent | a60016e0619d489f1c282aad6acd36f9d44e3459 (diff) | |
| download | redis-f4b5a4d8698cfee563ee0c054bd97ef5b46c5d26.tar.gz | |
Improve testsuite print of log file (#8805)
1. the `dump_logs` option would have printed only logs of servers that were
spawn before the test proc started, and not ones that the test proc
started inside it.
2. when a server proc catches an exception it should normally forward the
exception upwards, specifically when it's an assertion that should be
caught by a test proc above. however, in `durable` mode, we caught all
exceptions printed them to stdout and let the code continue,
this was wrong to do for assertions, which should have still been
propagated to the test function.
3. don't bother to search for crash log to print if we printed the the
entire log anyway
4. if no crash log was found, no need to print anything (i.e. the fact it
wasn't found)
5. rename warnings_from_file to crashlog_from_file
Diffstat (limited to 'tests/support/util.tcl')
| -rw-r--r-- | tests/support/util.tcl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/support/util.tcl b/tests/support/util.tcl index 5ea85c9e5..318cdf871 100644 --- a/tests/support/util.tcl +++ b/tests/support/util.tcl @@ -31,7 +31,7 @@ proc zlistAlikeSort {a b} { # Return all log lines starting with the first line that contains a warning. # Generally, this will be an assertion error with a stack trace. -proc warnings_from_file {filename} { +proc crashlog_from_file {filename} { set lines [split [exec cat $filename] "\n"] set matched 0 set logall 0 |