diff options
author | Oran Agra <oran@redislabs.com> | 2023-04-12 09:19:21 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-12 09:19:21 +0300 |
commit | 997fa41e99271cc5c3a79e9bf8a1332b3d9ab0c2 (patch) | |
tree | e9518b5a84c42b73ba39b735bc4d11010adc3d70 /tests/unit/maxmemory.tcl | |
parent | 45b8eea19f3e2491dec669f0745e513a4c9d7329 (diff) | |
download | redis-997fa41e99271cc5c3a79e9bf8a1332b3d9ab0c2.tar.gz |
Attempt to solve MacOS CI issues in GH Actions (#12013)
The MacOS CI in github actions often hangs without any logs. GH argues that
it's due to resource utilization, either running out of disk space, memory, or CPU
starvation, and thus the runner is terminated.
This PR contains multiple attempts to resolve this:
1. introducing pause_process instead of SIGSTOP, which waits for the process
to stop before resuming the test, possibly resolving race conditions in some tests,
this was a suspect since there was one test that could result in an infinite loop in that
case, in practice this didn't help, but still a good idea to keep.
2. disable the `save` config in many tests that don't need it, specifically ones that use
heavy writes and could create large files.
3. change the `populate` proc to use short pipeline rather than an infinite one.
4. use `--clients 1` in the macos CI so that we don't risk running multiple resource
demanding tests in parallel.
5. enable `--verbose` to be repeated to elevate verbosity and print more info to stdout
when a test or a server starts.
Diffstat (limited to 'tests/unit/maxmemory.tcl')
-rw-r--r-- | tests/unit/maxmemory.tcl | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tests/unit/maxmemory.tcl b/tests/unit/maxmemory.tcl index 564250f2e..54aba6715 100644 --- a/tests/unit/maxmemory.tcl +++ b/tests/unit/maxmemory.tcl @@ -350,7 +350,7 @@ proc test_slave_buffers {test_name cmd_count payload_len limit_memory pipeline} # put the slave to sleep set rd_slave [redis_deferring_client] - exec kill -SIGSTOP $slave_pid + pause_process $slave_pid # send some 10mb worth of commands that don't increase the memory usage if {$pipeline == 1} { @@ -399,7 +399,7 @@ proc test_slave_buffers {test_name cmd_count payload_len limit_memory pipeline} } # unfreeze slave process (after the 'test' succeeded or failed, but before we attempt to terminate the server - exec kill -SIGCONT $slave_pid + resume_process $slave_pid } } } |