summaryrefslogtreecommitdiff
path: root/tests/unit
diff options
context:
space:
mode:
authorMadelyn Olson <34459052+madolson@users.noreply.github.com>2023-03-07 15:06:53 -0800
committerGitHub <noreply@github.com>2023-03-07 15:06:53 -0800
commit2bb29e4aa375a76e81dfdcf6bbe418f0bf3461d1 (patch)
treedb246948c78e329fa8f518e6b1431a811fa82c43 /tests/unit
parent9958ab8b2cd17681962f5de83e6a94cf4189e9f3 (diff)
downloadredis-2bb29e4aa375a76e81dfdcf6bbe418f0bf3461d1.tar.gz
Always compact nodes in stream listpacks after creating new nodes (#11885)
This change attempts to alleviate a minor memory usage degradation for Redis 6.2 and onwards when using rather large objects (~2k) in streams. Introduced in #6281, we pre-allocate the head nodes of a stream to be 4kb, to limit the amount of unnecessary initial reallocations that are done. However, if we only ever allocate one object because 2 objects exceeds the max_stream_entry_size, we never actually shrink it to fit the single item. This can lead to a lot of excessive memory usage. For smaller item sizes this becomes less of an issue, as the overhead decreases as the items become smaller in size. This commit also changes the MEMORY USAGE of streams, since it was reporting the lpBytes instead of the allocated size. This introduced an observability issue when diagnosing the memory issue, since Redis reported the same amount of used bytes pre and post change, even though the new implementation allocated more memory.
Diffstat (limited to 'tests/unit')
0 files changed, 0 insertions, 0 deletions