diff options
| author | Andy Pan <panjf2000@gmail.com> | 2021-01-22 18:11:58 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-01-22 12:11:58 +0200 |
| commit | 8449a5df87017361000919d372b520a897c2de07 (patch) | |
| tree | 121b52e4460fb26f91b396d7535ae66edf71362f /tests | |
| parent | 0232778f35e949bb5e0b84f7cc63b230ddbd1c6d (diff) | |
| download | redis-8449a5df87017361000919d372b520a897c2de07.tar.gz | |
Sentinel tests, disable FD leak check, and print more details (#8376)
* Print more details about fd leaks
* temporarily prevent the leaks from failing the tests
Co-authored-by: Oran Agra <oran@redislabs.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/instances.tcl | 3 | ||||
| -rwxr-xr-x | tests/sentinel/tests/includes/notify.sh | 1 |
2 files changed, 3 insertions, 1 deletions
diff --git a/tests/instances.tcl b/tests/instances.tcl index 4e583eeb3..e35aaefa0 100644 --- a/tests/instances.tcl +++ b/tests/instances.tcl @@ -423,7 +423,8 @@ proc end_tests {} { if { [file exists $sentinel_fd_leaks_file] } { puts [colorstr red "WARNING: sentinel test(s) failed, there are leaked fds in sentinel:"] puts [exec cat $sentinel_fd_leaks_file] - exit 1 + # temporarily disabling this error from failing the tests until leaks are fixed. + #exit 1 } if {$::failed == 0 } { diff --git a/tests/sentinel/tests/includes/notify.sh b/tests/sentinel/tests/includes/notify.sh index 2365f1d3a..5de0eaf76 100755 --- a/tests/sentinel/tests/includes/notify.sh +++ b/tests/sentinel/tests/includes/notify.sh @@ -16,5 +16,6 @@ then if [ ! -f $sentinel_fd_leaks_file ] then ls -l /proc/self/fd | cat >> $sentinel_fd_leaks_file + lsof -p $$ | cat >> $sentinel_fd_leaks_file fi fi |