diff options
| author | Madelyn Olson <34459052+madolson@users.noreply.github.com> | 2022-04-11 22:16:17 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-11 22:16:17 -0700 |
| commit | 8bd01a07ae75609a36335ab34b37da41da1b1bf2 (patch) | |
| tree | 554db739e86b21da964803b9534e5636ee8c00d8 /tests | |
| parent | 4c6d9bbd626bb25cf7d154ea0b7d347172015cfb (diff) | |
| download | redis-8bd01a07ae75609a36335ab34b37da41da1b1bf2.tar.gz | |
Allow specifying ACL reason for module log entry (#10559)
Allow specifying an ACL log reason, which is shown in the log. Right now it always shows "unknown", which is a little bit cryptic. This is a breaking change, but this API was added as part of 7 so it seems ok to stabilize it still.
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/modules/aclcheck.c | 2 | ||||
| -rw-r--r-- | tests/unit/moduleapi/aclcheck.tcl | 3 |
2 files changed, 4 insertions, 1 deletions
diff --git a/tests/modules/aclcheck.c b/tests/modules/aclcheck.c index 8a9d468a6..9f4564d27 100644 --- a/tests/modules/aclcheck.c +++ b/tests/modules/aclcheck.c @@ -92,7 +92,7 @@ int rm_call_aclcheck_cmd(RedisModuleCtx *ctx, RedisModuleUser *user, RedisModule if (ret != 0) { RedisModule_ReplyWithError(ctx, "DENIED CMD"); /* Add entry to ACL log */ - RedisModule_ACLAddLogEntry(ctx, user, argv[1]); + RedisModule_ACLAddLogEntry(ctx, user, argv[1], REDISMODULE_ACL_LOG_CMD); return REDISMODULE_OK; } diff --git a/tests/unit/moduleapi/aclcheck.tcl b/tests/unit/moduleapi/aclcheck.tcl index 5adf65371..d96ea89cf 100644 --- a/tests/unit/moduleapi/aclcheck.tcl +++ b/tests/unit/moduleapi/aclcheck.tcl @@ -16,6 +16,7 @@ start_server {tags {"modules acl"}} { assert {[dict get $entry username] eq {default}} assert {[dict get $entry context] eq {module}} assert {[dict get $entry object] eq {set}} + assert {[dict get $entry reason] eq {command}} } test {test module check acl for key perm} { @@ -75,6 +76,7 @@ start_server {tags {"modules acl"}} { assert {[dict get $entry username] eq {default}} assert {[dict get $entry context] eq {module}} assert {[dict get $entry object] eq {z}} + assert {[dict get $entry reason] eq {key}} # rm call check for command permission r acl setuser default -set @@ -88,6 +90,7 @@ start_server {tags {"modules acl"}} { assert {[dict get $entry username] eq {default}} assert {[dict get $entry context] eq {module}} assert {[dict get $entry object] eq {set}} + assert {[dict get $entry reason] eq {command}} } test "Unload the module - aclcheck" { |