diff options
author | Wen Hui <wen.hui.ware@gmail.com> | 2023-04-19 02:08:11 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-04-19 09:08:11 +0300 |
commit | b220e6b45015a4e06d385cb0ed30606e50968bf6 (patch) | |
tree | db1fbe98caf72aa4825e03a5caa72812fdd7995c /utils | |
parent | 528b0e691ed7f2c07b7bac29ea4234c1fb7df18a (diff) | |
download | redis-b220e6b45015a4e06d385cb0ed30606e50968bf6.tar.gz |
Updating reply_schema for sentinal commands (#12018)
Some sentinel subcommands are missing the reply_schema in the json file,
so add the proper reply_schema part in json file as sentinel replicas commands.
The schema validator was skipping coverage test for sentinel commands, this was initially
done just in order to focus on redis commands and leave sentinel coverage for later,
so this check is now removed.
sentinel commands that were missing reply schema:
* sentinel masters
* sentinel myid
* sentinel sentinels <master-name>
* sentinel slaves (deprecated) <master-name>
Diffstat (limited to 'utils')
-rwxr-xr-x | utils/req-res-log-validator.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/utils/req-res-log-validator.py b/utils/req-res-log-validator.py index 2cb399b6a..b96e7f4dc 100755 --- a/utils/req-res-log-validator.py +++ b/utils/req-res-log-validator.py @@ -334,9 +334,7 @@ if __name__ == '__main__': print("Hits per command:") for k, v in sorted(command_counter.items()): print(f" {k}: {v}") - # We don't care about SENTINEL commands - not_hit = set(filter(lambda x: not x.startswith("sentinel"), - set(docs.keys()) - set(command_counter.keys()) - set(IGNORED_COMMANDS))) + not_hit = set(set(docs.keys()) - set(command_counter.keys()) - set(IGNORED_COMMANDS)) if not_hit: if args.verbose: print("WARNING! The following commands were not hit at all:") |