diff options
| author | Binbin <binloveplay1314@qq.com> | 2023-04-27 14:32:14 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-27 09:32:14 +0300 |
| commit | d659c734569be4ed32a270bac2527ccf35418c43 (patch) | |
| tree | ac24eb78d850a93a63adefefb5f0476d635df215 /utils | |
| parent | 5ddc0af33e8d071d2883a12ceb10336fdd25f843 (diff) | |
| download | redis-d659c734569be4ed32a270bac2527ccf35418c43.tar.gz | |
Add missing reply schema and coverage tests (#12079)
The change in #12018 break the CI (fixed by #12083).
There are quite a few sentinel commands that are missing both test coverage and also schema.
PR added reply-schema to the following commands:
- sentinel debug
- sentinel info-cache
- sentinel pendding-scripts
- sentinel reset
- sentinel simulate-failure
Added some very basic tests for other sentinel commands, just so that they have some coverage.
- sentinel help
- sentinel masters
- sentinel myid
- sentinel sentinels
- sentinel slaves
These tests should be improved / replaced in a followup PR.
Diffstat (limited to 'utils')
| -rwxr-xr-x | utils/req-res-log-validator.py | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/utils/req-res-log-validator.py b/utils/req-res-log-validator.py index 1f11b0307..46c110019 100755 --- a/utils/req-res-log-validator.py +++ b/utils/req-res-log-validator.py @@ -58,17 +58,6 @@ IGNORED_COMMANDS = { # Commands to which we decided not write a reply schema "pfdebug", "lolwut", - # TODO: write a reply schema for the following commands - "sentinel|debug", - "sentinel|info-cache", - "sentinel|pending-scripts", - "sentinel|reset", - "sentinel|simulate-failure", - "sentinel|help", - "sentinel|masters", - "sentinel|myid", - "sentinel|sentinels", - "sentinel|slaves", } class Request(object): |