diff options
| author | Panu Matilainen <pmatilai@redhat.com> | 2012-12-19 12:32:52 +0200 |
|---|---|---|
| committer | Panu Matilainen <pmatilai@redhat.com> | 2012-12-19 12:32:52 +0200 |
| commit | d73535e1a9dc5095e78475adc5b636d99f01efa9 (patch) | |
| tree | a3375301d86906d3e7e32ddfd26ea9bddaaaadaa /lib/rpmts_internal.h | |
| parent | aa6af71d457be5d78252f23ea68322dcaf199e4e (diff) | |
| download | rpm-d73535e1a9dc5095e78475adc5b636d99f01efa9.tar.gz | |
Handle transaction global pool allocation centrally in rpmtsPool()
- Previously the pool would only get allocated on successfull addition
of install or erasure elements, causing assert() failures on
operations on empty transaction set, which should be just a no-op,
not an error.
- Make rpmtsPool() create the pool if it doesn't exist, update relevant
users to call rpmtsPool() instead of directly accessing tsmem->pool,
this avoids having to worry about pool existence in all the various cases.
- Also fix up the pool-related comment on rpmtsEmpty(): pools does not
and can not support emptying as it could break references to its
contents. Per-string refcount would be needed for emptying support.
Diffstat (limited to 'lib/rpmts_internal.h')
| -rw-r--r-- | lib/rpmts_internal.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/rpmts_internal.h b/lib/rpmts_internal.h index a22c89267..d4f25e17e 100644 --- a/lib/rpmts_internal.h +++ b/lib/rpmts_internal.h @@ -76,7 +76,7 @@ extern "C" { #endif /** \ingroup rpmts - * Return transaction global string pool handle + * Return transaction global string pool handle, creating the pool if needed. * @param ts transaction set * @return string pool handle (weak ref) */ |