summaryrefslogtreecommitdiff
path: root/rpmio/rpmglob.c
diff options
context:
space:
mode:
authorPanu Matilainen <pmatilai@redhat.com>2018-10-10 11:31:49 +0300
committerPanu Matilainen <pmatilai@redhat.com>2018-10-10 11:33:30 +0300
commitfa10245c91cdce82dcdaebf374a7d94694e6ba93 (patch)
tree70e22aa056c1503c3fe3f4cb660275dc97dbbfd0 /rpmio/rpmglob.c
parentff3d8ac2e5cb4456ad1355f227f3ccef08e01972 (diff)
downloadrpm-fa10245c91cdce82dcdaebf374a7d94694e6ba93.tar.gz
Fix buffer overrun in glob tilde expansion
Similar to 8dda888e14df323e1dc1e76a42851e68980658cd but this one noticed by covscan: not enough space for the terminating \0.
Diffstat (limited to 'rpmio/rpmglob.c')
-rw-r--r--rpmio/rpmglob.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/rpmio/rpmglob.c b/rpmio/rpmglob.c
index 819d79acd..3c497cbef 100644
--- a/rpmio/rpmglob.c
+++ b/rpmio/rpmglob.c
@@ -314,7 +314,7 @@ glob(const char *pattern, int flags,
else {
char *newp;
size_t home_len = strlen(home_dir);
- newp = (char *) alloca(home_len + dirlen);
+ newp = (char *) alloca(home_len + dirlen + 1);
mempcpy(mempcpy(newp, home_dir, home_len),
&dirname[1], dirlen);
dirname = newp;