summaryrefslogtreecommitdiff
path: root/build/parseDescription.c
Commit message (Collapse)AuthorAgeFilesLines
* Fix POPT_ARG_STRING memleaks in librpmbuildPanu Matilainen2020-02-031-4/+7
| | | | | | | | | popt always returned malloc'ed memory for POPT_ARG_STRING items, but for whatever historical reason rpm systematically passed const char * pointers as targets, making them look non-freeable. Besides changing just the types and adding free()'s, const-correctness requires extra tweaks as there's mixed use from string literals and poptGetArg() which does return const pointers.
* Fix segfault regression on empty script or description at end of specPanu Matilainen2019-08-191-2/+7
| | | | | | | | | | | | | | More ripples from the parseLines() unification (commits 91e8d826e473c98209ba9db0ea06ab884557076c to 783e2dc0b424afdf0a5d2add368279cb63016897), the callers used to explicitly allocate an empty string buffer, but with lazy allocation from parseLines() they're getting NULL in the special circumstance of being last in the spec, and no "body". Specifically this happens with empty %description or scriptlet without a body, eg "%post -p /sbin/ldconfig". The script regression report + reproducer and a preliminary patch originally from RhBug:1732276 by nvwarr.
* Port parseDescription() to use parseLines(), no functional changesPanu Matilainen2019-04-171-20/+4
|
* Make package exists/does not exist error more informativePanu Matilainen2016-11-111-5/+1
| | | | | | | | | Rearrange the message to "linenum: line: message" which is a more logical order of things (I think), and in particular, include the actual actual package name in the message. In order to do that, consolidate the error logging inside lookupPackage() where we now get a slightly hysterical logic around the error messages but what the hey, its not like this is an exported API.
* Check for duplicate %description sections tooPanu Matilainen2014-01-291-14/+3
| | | | | | | - Similarly to Group, Summary etc, this is complicated by possible presence of language-specific versions, but now that we have a function to handle it... - Should *really* close out ticket #27
* Clean up + plug memleak in parseDescription()Panu Matilainen2011-05-271-4/+4
| | | | | | - Eliminate dead NULL-assignments of local variables on exit - Move stringbuf free to exit, previously error on readLine() leaked memory here
* Eliminate unused spectag and speclines goo from specPanu Matilainen2010-10-291-4/+0
| | | | | | | | | - These were used, back in the day, to implement a hidden --specedit switch, which in all its glory did: print a copy of a spec file, with group, summary and description looked up from specspo. This huge pile of junk was left behind from kicking out the useless "feature" in commits 7b95061d3b77d8e6b3c80e856b66f49b393511ba and 0f991a14209054da7c45c46e96750738fc62874d.
* Handle --nolang as another spec parse flagPanu Matilainen2010-09-011-3/+1
|
* Mass eviction of remaining internal helpers in librpmbuild APIPanu Matilainen2010-08-251-1/+1
| | | | | | | | | | | - Yank everything qualifying as "internal helper function" into internal-only headers, loosely grouped as follows: 1) Everything involving spec-manipulation goes into rpmbuild_internal.h 2) All other miscellaneous helpers go into rpmbuild_misc.h - This leaves us a rather minimal, and nearly useful API into librpmbuild: Users need to be able to parse a spec, query or build (parts of) it and free up the spec structure when done. This is what we have now, various still exposed structures not counting.
* Replace equal/not equal uses of str[n]cmp() with rstreq[n] in build codePanu Matilainen2009-08-311-1/+1
|
* Move declarations of local variables for parsing functionsJindrich Novy2008-12-091-13/+7
| | | | from global scope. Compilers aren't that stupid these days
* Make parseDescription() return PART_ERROR on errorsPanu Matilainen2008-05-051-9/+7
|
* Make rpmtag.h standalone, include from rpmtypes.hPanu Matilainen2008-02-031-1/+1
| | | | | | - permits header.h to use the tag types - revert other includes back to header.h, more crazy #include churn... - rpmTagTable etc in header.h for now, don't really belong there but...
* rpmlib.h mass evictionPanu Matilainen2008-01-301-0/+1
| | | | | - explicitly include what's really needed instead - document remaining uses
* Switch to <rpm/foo.h> style for public headersPanu Matilainen2007-12-081-2/+2
| | | | - adjust include paths accordingly
* Yet more rpmbuild fixups from rpmerr.h removal (partly from rpm5.org)Panu Matilainen2007-12-071-4/+4
| | | | - additionally use rpmRC return types instead of numbers where appropriate
* Use #include <x.h> syntax to include public headers.Ralf Corsépius2007-11-231-2/+2
|
* Lose rpmerr.h for goodPanu Matilainen2007-11-191-1/+1
|
* Replace all RPMERR_* etc uses with corresponding RPMLOG_* levelsPanu Matilainen2007-11-191-9/+9
|
* Make rpmerr.h private, include directly where needed.Panu Matilainen2007-10-091-0/+1
|
* Replace all rpmError() uses with rpmlog()Panu Matilainen2007-10-091-5/+5
|
* Rename Spec -> rpmSpec for namespacingPanu Matilainen2007-09-211-1/+1
|
* Remove splint tags.Ralf Corsépius2007-09-111-10/+2
|
* - permit secondary tag match patterns with RPMQV_ALL.jbj2003-04-161-21/+13
| | | | | | CVS patchset: 6754 CVS date: 2003/04/16 22:13:18
* Converging on lclint-3.0.17 strict level.jbj2001-10-171-0/+4
| | | | | | CVS patchset: 5118 CVS date: 2001/10/17 16:43:36
* lclint fiddles to annotate globals.jbj2001-10-151-0/+4
| | | | | | CVS patchset: 5106 CVS date: 2001/10/15 03:22:10
* lclint fiddles.jbj2001-06-041-1/+3
| | | | | | CVS patchset: 4833 CVS date: 2001/06/04 13:55:58
* - fix: specfile queries with BuildArch: (#27589).jbj2001-05-061-1/+1
| | | | | | CVS patchset: 4746 CVS date: 2001/05/06 19:17:14
* - enough lclint annotations and fiddles already.jbj2001-05-051-6/+6
| | | | | | CVS patchset: 4741 CVS date: 2001/05/05 19:28:32
* - yet more boring lclint annotations and fiddles.jbj2001-04-301-1/+1
| | | | | | CVS patchset: 4732 CVS date: 2001/04/30 22:32:22
* - globalize _free(3) wrapper in rpmlib.h, consistent usage throughout.jbj2001-04-291-5/+5
| | | | | | | | | - internalize locale insensitive ctype(3) in rpmio.h - boring lclint annotations and fiddles. CVS patchset: 4721 CVS date: 2001/04/29 01:05:43
* - fix: extra newline in many error messages (#23947).jbj2001-01-151-5/+6
| | | | | | | | | - fix: rpm -Va with db1 needs per-iterator, not per-index, offset. - add install/remove transaction id tags. CVS patchset: 4441 CVS date: 2001/01/15 23:09:42
* doxygen annotations for build/*.jbj2001-01-111-1/+0
| | | | | | | | | - fix: don't hang on build error. - fix: remove "error: " prefix from signature verification message. CVS patchset: 4426 CVS date: 2001/01/11 14:13:04
* Sync with rpm-4_0 branch.jbj2000-12-121-0/+1
| | | | | | CVS patchset: 4338 CVS date: 2000/12/12 20:03:45
* Doxygen annotations.jbj2000-08-271-1/+2
| | | | | | CVS patchset: 4130 CVS date: 2000/08/27 19:18:25
* Documentation sugar.jbj2000-01-241-0/+5
| | | | | | CVS patchset: 3533 CVS date: 2000/01/24 20:02:32
* use compressed filenames on install side.jbj1999-10-271-5/+4
| | | | | | | | start unifying FD types, CFD_t now gone. CVS patchset: 3402 CVS date: 1999/10/27 23:18:10
* lclint annotations from build.jbj1999-10-041-2/+2
| | | | | | CVS patchset: 3366 CVS date: 1999/10/04 19:40:03
* Start experimental support for bzip2 payloads.jbj1999-09-201-2/+0
| | | | | | CVS patchset: 3309 CVS date: 1999/09/20 13:34:47
* permit substitution of I18N strings from PO meta-catalogues.jbj1999-02-221-0/+4
| | | | | | CVS patchset: 2824 CVS date: 1999/02/22 17:44:57
* lclint noise.jbj1998-11-191-3/+3
| | | | | | CVS patchset: 2544 CVS date: 1998/11/19 19:10:23
* Consolidate i18n baggage into AM_GNU_GETTEXT and system.h.jbj1998-10-081-1/+0
| | | | | | CVS patchset: 2425 CVS date: 1998/10/08 14:59:17
* add Slovak translation (Stanislav Meduna <stano@trillian.eunet.sk>)jbj1998-09-271-5/+6
| | | | | | | | gettextify rpmMessage/rpmError/fprintf messages. CVS patchset: 2368 CVS date: 1998/09/27 22:03:52
* Sync with 2.5.2 branch patches.jbj1998-08-111-1/+5
| | | | | | | | | cpio_gzip: dup the fd before doing gzdopen (Thanks Erik!) add --noLang to skip non-default languages. CVS patchset: 2243 CVS date: 1998/08/11 18:24:48
* Consolidated includes for librpmbuild API.jbj1998-07-301-7/+2
| | | | | | CVS patchset: 2213 CVS date: 1998/07/30 22:09:42
* Aggregate system includes into system.h.jbj1998-07-251-1/+1
| | | | | | | | | Rearrange functions to minimize exported routines in librpmbuild API. VS: ---------------------------------------------------------------------- CVS patchset: 2183 CVS date: 1998/07/25 21:00:26
* Actually catch errors from readLine()marc1998-05-201-2/+9
| | | | | | CVS patchset: 2119 CVS date: 1998/05/20 17:05:26
* Do not remove comments in scriptsmarc1998-05-011-2/+2
| | | | | | CVS patchset: 2101 CVS date: 1998/05/01 01:54:27
* handle negative return values from poptGetNextOpt()ewt1998-04-021-1/+2
| | | | | | CVS patchset: 2062 CVS date: 1998/04/02 18:31:12
* 1) include cleanups for portabilityewt1998-03-041-8/+14
| | | | | | | | | | | 2) pulled popt structures and variables out of functions -- they need to be global due to stupid compilers 3) modified the Makefile to use relative dependencies, and make dependencies optional CVS patchset: 2020 CVS date: 1998/03/04 16:51:06