summaryrefslogtreecommitdiff
path: root/sign
Commit message (Collapse)AuthorAgeFilesLines
* Handle IMA as an imported target, take IIMichal Domonkos2023-04-111-2/+1
| | | | Another attempt at commit 7184fb80137363e39d79e2b5a0eb2c4fb060cc2e.
* Revert "Handle IMA as an imported target"Panu Matilainen2023-04-061-1/+2
| | | | | | This has brainfarts and is broken. This reverts commit 7184fb80137363e39d79e2b5a0eb2c4fb060cc2e.
* Handle IMA as an imported targetPanu Matilainen2023-04-061-2/+1
| | | | | | | Most of our dependencies are imported targets already, so while for just one site this isn't actually any shorter in terms of LoC it's more consistent with the surroundings in the consuming site, and more so if we ever need to link to this from some other place.
* Fix ignoring exit code of child scripts in case of EINTRКоренберг Марк2023-03-081-2/+10
|
* Copy original lead on signing instead of recreatingPanu Matilainen2023-03-071-11/+13
| | | | | | | | | | | | Fixes a regression from commit 3255273ae0fabd03c9738249a29c9c1e15f28f64 where the arch and os fields of the lead may change depending on the package arch and the host where --addsign/--delsign is executed. This is hard to test for specifically as the test-suite can run on any architecture, but the bit-per-bit comparison test added in the previous commit will catch differences here too. Fixes: #1326
* Fix signature reserved space not restored on --delsign (#2382)Panu Matilainen2023-03-071-4/+10
| | | | | | | | | | Fixes a regression from commit 5c279fb149a44a1bc4d19e11c3c01942732b8486 simplifying this a bit too much, and failing to restore the reclaimed reserved signature space on after --delsign. Add a test-case to ensure --addsign + --delsign returns the package to its original state bit-by-bit. Fixes: #2382
* Implement proper imaevm detection in the cmake buildPanu Matilainen2022-12-131-1/+2
| | | | | | | Abort the build if imaevm enabled but header+library not present, use detected values. Check for lsetxattr() availability. Drop unnecessary imaevm linkage from the plugin, the plugin only manipulates xattrs and does not need the IMA library.
* Avoid unnecessary variables for cmake target data, part 1Panu Matilainen2022-11-281-7/+4
| | | | | | The foo_SOURCES style isn't really in cmake ethos, and is wholly unnecessary here: target_sources() achieves the same exact thing in a slightly more straightforward way.
* Use cmake imported targets to let it sort out the compiler flag detailsPanu Matilainen2022-11-281-1/+1
| | | | | | | | | | | | | | These imported targets passed to target_link_library() are supposed to handle all the pesky compilation, linkage etc details behind the scenes. I was pretty sure I was missing a trick with this, but this sure isn't exactly underlined in the documentation. Unroll the supposedly helpful loop for handling plugins: turns out doing this cmake native way is plenty shorter and more obvious too. The unroll kinda belongs to a separate commit but that'd be rather painful for very little if any gain. Fixes: #2269 and a whole class of similar cases, allegedly
* Issue a warning when signing created an OpenPGP v3 signaturePanu Matilainen2022-11-251-0/+7
| | | | | | | | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=2141686 revealed that much of the rpm-ecosystem is still using the obsolete v3 OpenPGP signature format, I think largely due to workarounds for legacy rpm versions (from around the turn of the millennium) that have just been forgotten in place. Lets at least issue a wake-up warning when that happens. Unfortunately this is can't really be tested as current GnuPG versions just ignore any --force-v3-sigs arguments. Fixes: #2286
* Use proper name (OpenPGP) when referring to the standard in messagesPanu Matilainen2022-11-251-3/+3
|
* Fix fsverity plugin build, obviously never worked with cmake before, dohPanu Matilainen2022-11-031-1/+1
|
* Remove autotools buildPanu Matilainen2022-10-211-29/+0
| | | | | | | | | | There are some missing bits and pieces still to be done for cmake build, but that is so much easier if you don't have to worry about keeping compatibility with the system you're about to remove that it doesn't make sense to drag this on any further. The sooner this is over, the sooner it is over and we can start making use of cmake's advantages instead of just trying to bend over backwards to maintain compatibility with the autotools build.
* Fix fsverity (and imaevm) build under cmakePanu Matilainen2022-10-201-1/+1
|
* Fix cmake build without IMAEVM and FSVERITYPanu Matilainen2022-09-291-2/+4
| | | | | The IMA define needs to match what the code expects. Conditionalize the relevant sources.
* Add an experimental CMake build systemPanu Matilainen2022-06-281-0/+19
| | | | | | | | | | | | | | | | | This is an incomplete release-early version, NOT intended or suitable for production use. It is intended to replace the autotools based buildsystem in rpm 4.20, until then it'll be developed alongside it. This causes some extra complications of course, but then we avoid a huge flag-day, and that matters more. To those wondering why cmake and not ${myfavorite}: the community around us effectively made that choice for us. We've made a lot of noise about bootstrap dependencies. When libsolv, dnf and all the related stack is powered by cmake build, it'd be just foolish to go with anything else. This way people working on the rpm stack have only one build system to learn, there's peer support available nearby and bootstrap dependencies are reduced, not increased. It also doesn't hurt that cmake is actually and actively maintained.
* Remove NSS referencesDemi Marie Obenour2022-03-181-1/+1
| | | | RPM doesn’t use NSS anymore.
* Eliminate the strange include pre-build install machineryPanu Matilainen2022-03-102-61/+1
| | | | | | | | | | | Introduced back in 2007 in 583140460100ea99553d883174065ca22a3099b2 the point was to fake up a sane public header structure with minimal internal disruption, TEMPORARILY. I think 15 years is temporary enough. The machinery has worked rather well for what it is, but having the headers appear in multiple locations is weird and confusing to people, plus this "physical" separation makes it far more clearer what is a public header and what isn't.
* Remove leading directories from doxygen notationPanu Matilainen2022-03-101-1/+1
| | | | | These don't represent the exported include structure so they're probably more harmful than anything else.
* Use proper addressing for our public headers everywherePanu Matilainen2022-03-102-5/+5
|
* Fix missing include from d44be2cbc1c3265d55f05b47daa69334a7a133e6Panu Matilainen2022-03-031-0/+1
| | | | Somehow this managed to sneak past unnoticed
* Rename pgpHexStr() to rpmhex(), but preserve ABI for nowPanu Matilainen2022-02-252-3/+3
| | | | | | Fixup internal callers to use rpmhex(), deprecate pgpHexStr(). pgpHexStr() should be dropped at next soname bump, whenever that happens.
* Move pgpHexStr() out of rpmpgp.h, it has nothing to do with PGPPanu Matilainen2022-02-251-1/+1
|
* Detach rpm's hash algorithm values from PGP hash algorith valuesPanu Matilainen2022-02-251-11/+12
| | | | | | | | | At this point this is quite literally merely a symbolic change, as values from PGP hash algo are assumed equal to RPM hash algos, but it's a necessary first step to supporting hashes not included in RFC-4880. Fixes: #1899
* Fix IMA signature fubar, take III (#1833, RhBug:2018937)Panu Matilainen2022-02-111-1/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | At least ECDSA and RSA signatures can vary in length, but the IMA code assumes constant lengths and thus may either place invalid signatures on disk from either truncating or overshooting, and segfault if the stars are just so. As we can't assume static lengths and attempts to use maximum length have proven problematic for other reasons, use a data structure that can actually handle variable length data properly: store offsets into the decoded binary blob and use them to calculate lengths when needed, empty data is simply consequtive identical offsets. This avoids a whole class of silly overflow issues with multiplying, makes zero-length data actually presentable in the data structure and saves memory too. Add tests to show behavior with variable length signatures and missing signatures. Additionally update the signing code to store the largest IMA signature length rather than what happened to be last to be on the safe side. We can't rely on this value due to invalid packages being out there, but then we need to calculate the lengths on rpmfiles populate so there's not a lot to gain anyhow. Fixes: #1833
* Revert whack-a-mole attempts to fix IMA as brokenPanu Matilainen2022-02-111-4/+1
| | | | | | This reverts commits a79d7ae0f0996815d18cdf11226817900b875765 and 31e9daf823f7052135d1decc0802b6fa775a88c5 which are still dangerously flawed.
* Do not unset $MALLOC_CHECK_Denys Vlasenko2022-01-241-1/+0
| | | | | | | How do we even _know_ user wants to debug malloc in rpmbuild, maybe user wants to debug it in _the child_? Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
* Fix __cplusplus misspelled as _cplusplus.Peter Pentchev2022-01-182-2/+2
|
* Close file before replacing signedEvgeniy Taishev2022-01-181-0/+4
|
* Fix use-after-free in haveSignature()Michal Domonkos2022-01-101-1/+1
| | | | | | | | | | | pgpPrtParams() may leave sig2 unchanged and if we're not in the very first iteration of the while() loop, we could pass a freed pointer to pgpDigParamsCmp(). Fix by setting it to NULL after freeing. Found by Coverity, after commit bd36c5d (subkey binding validation), although note that the commit didn't introduce this bug; it just seems to have been a false negative that got "fixed" by the changes in pgpPrtParams() in that commit.
* Fix IMA signature lengths assumed constant (#1833, RhBug:2018937)Panu Matilainen2021-12-131-1/+4
| | | | | | | | | | | | | | | | | | | | At least ECDSA and RSA signatures can vary in length, but the IMA code assumes constant lengths and thus may either place invalid signatures on disk from either truncating or overshooting, and segfault if the stars are just so. Luckily the signatures are stored as strings so we can calculate the actual lengths at runtime and ignore the stored constant length info. Extend hex2bin() to optionally calculate the lengths and maximum, and use these for returning IMA data from the rpmfi(les) API. Additionally update the signing code to store the largest IMA signature length rather than what happened to be last to be on the safe side. We can't rely on this value due to invalid packages being out there, but then we need to calculate the lengths on rpmfiles populate so there's not a lot to gain anyhow. Fixes: #1833
* rpmsign: support EdDSA signaturesDemi Marie Obenour2021-03-151-0/+1
| | | | They were previously rejected
* Eliminate remaining uses of unsafe headerCopyLoad() in the codebasePanu Matilainen2021-03-111-1/+1
| | | | | | There's no way to safely validate an object to which only a void pointer is given. Use headerImport() and pass a size to make verification possible, headerCopyLoad() has been long deprecated anyway.
* rpmsign: Add argument to specify algorithm for fsverity signaturesJes Sorensen2020-09-043-6/+23
| | | | | | | | | The argument --verity-algo can be used to specify the algorithm for the fsverity signatures. If nothing is specified, this will default to sha256. The available algorithms depend on libfsverity, currently sha256 and sha512 are supported. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* Add --delfilesign flag to delete IMA and fsverity file signaturesJes Sorensen2020-09-042-1/+25
| | | | | | | | | This allows a user to remove both types of file signatures from the package. Previously there was no way to delete IMA signatures, only replace them by first removing the package signature and then resigning the package and the files. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* fsverity - add tag for fsverity algorithmJes Sorensen2020-09-041-4/+28
| | | | | | | The default algorith is SHA256, but fsverity allows for other algorithms, so add a tag to handle this. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* rpmsignverity.c: Clean up debug loggingJes Sorensen2020-09-041-5/+0
| | | | | | Put most logging in one place and avoid printing the same info twice. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* Generate a zero-length signature for symlinksJes Sorensen2020-09-041-1/+4
| | | | | | | | The fsverity utility follows the symlink when generating a signature. Since we don't want to sign the same file twice, we need to skip these links, and instead just generate a dummy zero-length signature here. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* Process verity tag on package readJes Sorensen2020-09-041-4/+16
| | | | | | | This processes verity signature tags on package read, and provides accessor functions to access them. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* rpmSignVerity: Generate signatures for files not present in archiveJes Sorensen2020-09-041-12/+43
| | | | | | | | | | This generates signatures for all files in the archive, then picks up ghost files from the header metadata and generates signatures for them as well. It finally submits them to RPMTAG_VERITYSIGNATURES in header file order as we cannot rely on archive order and header order being the same. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* rpmsignverity: Add verity signature headers to the packageJes Sorensen2020-09-042-36/+83
| | | | | | | | This adds the array of verity signatures, and a signature length header. We use 4K block for the Merkle tree, and rely on the kernel doing the right thing. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* Implement rpmSignVerity()Jes Sorensen2020-09-043-0/+186
| | | | | | | This generates the root Merkle tree hash and signs it using the specified key and certificate. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* Add basic autoconf and framework for fsverity supportJes Sorensen2020-09-042-0/+6
| | | | | | Use the same signing key argument as is used for IMA file signing. Signed-off-by: Jes Sorensen <jsorensen@fb.com>
* Work around buggy signature region preventing resigning (RhBug:1851508)Panu Matilainen2020-08-131-2/+10
| | | | | | | | | | | | | Various proprietary packages in the wild have subtly malformed data in the signature header, in particular wrt the immutable region size, presumably from using some in-house/3rd party signing tools which do not understand the immutable region business at all. This can prevent resigning and signature deletion on such packages due to the more thorough checking that rpmsign does. As the old wisdom goes, be liberal in what you accept... we can easily work around the crud by just taking a fresh copy of the contents that are legit as such (otherwise the package would be uninstallable).
* GPG: refactor: clean up exit labelMichal Domonkos2020-06-241-15/+7
| | | | Remove the redundant close()/fclose() and waitpid() calls.
* GPG: Switch back to pipe(7) for signingMichal Domonkos2020-06-241-82/+30
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When it comes to IPC with the GPG subprocess that we spawn to sign packages for us, there has been an evolution of changes over the years. Initially, we used temporary files to dump package data (header+payload) to disk, and pointed GPG to those. That being an insanely expensive operation, we later opted for a pipe bound to stdin on the reader side [1] to avoid the unnecessary I/O. When GPG 2.1 came along, our own passphrase entry logic stopped working so we decided to offload [3] that to GPG instead, for which we also needed to swap the pipe for a named pipe (FIFO), to free [2] stdin for GPG's own passphrase entry program (pinentry). Fast forward to the present, it has become apparent that the FIFO semantics is not the right choice for us either, as it brings about a handful of synchronization issues, all of which stem from the fact that the GPG subprocess, which we cannot control, may or may not open the input file (our FIFO) for reading before it terminates, causing either process to hang. That's because an open(2) call on a FIFO blocks until the other end is also opened. One particular case where such a deadlock can happen is an expired key [4]; GPG would error out without ever opening the input file (and rightly so), making RPM stuck. In a nutshell, here's what the two processes do: RPM parent: * spawn GPG child * open FIFO for writing (blocks) * write data * close FIFO GPG child: * check key validity <-- may terminate here * open FIFO for reading (blocks) * read data * close FIFO Which may result in the following execution order: * parent: spawn GPG child * parent: open FIFO for writing (blocks) * child: check key validity (key expired!) * child: terminate with an error (sends SIGCHLD) * parent: (continues blocking...) Now, one way to unblock the parent would be to install a SIGCHLD handler with SA_RESTART and make it open the FIFO for reading (with O_NONBLOCK) iff the signal comes from our GPG child (note that RPM can also be used as a library) so that the restarted open call unblocks right away. This would, however, still not be entirely safe from race conditions; if there were other subprocesses, all terminating about the same time, their SIGCHLD instances could prevent us from receiving the one from GPG; this is because standard signals do not queue (see signal(7) for a detailed explanation). Another way would be to spawn GPG from a wrapper process whose sole purpose would be to wait(2) for GPG and to open the FIFO if it failed (without O_NONBLOCK, to ensure the wrapper doesn't exit before the parent's open call). This would work as long as we could tell exactly which errors cause GPG to not open the input file, but since that's not documented, we would have to rely on implementation details, not to mention the added complexity and ugliness of such a solution, so that's also a no-go. Lastly, why not just use O_NONBLOCK in the parent, to prevent it from blocking in the first place? Since GPG does not use O_NONBLOCK, this would just push the problem down to the child; if the parent is too fast and manages to close the FIFO before the child gets a chance to open it, the child would get stuck once it gets there (thus making the parent stuck on the wait call). Luckily, it turns out we actually can take over stdin *and* have GPG use its pinentry program at the same time! All we need is to make sure the GPG_TTY environment variable is set to the current terminal (see gpg-agent(1)). This variable is used [5] by GPG as a fall-back when it fails to obtain the terminal connected to stdin using ttyname(3), such as when it is redirected to a pipe. Thus, in this commit (mostly adapted from the reverse of [2]), we revert to using the good old pipe(7) which not only avoids race conditions (as it does not cause open to block), but is also more suitable for this task in general. (For the record, GPGme also uses [6] a regular pipe for the IPC.) Since we have access to the original stdin before redirection, we set GPG_TTY accordingly (if previously unset), to keep pinentry working. This commit also resolves the RHBZ linked in [4]. Note that, in the case of key expiration, GPG isn't particularly specific in the error message or exit code; all it says is "Unusable secret key" and returns code 2. For that reason, we can't print anything helpful to stderr either. [1] commit 1aace27fb9541c1d176d8795a1d7872949f8f551 [2] commit 6a8924b4c9df8e3597f7b4aa3de46498d390c5a8 [3] commit 0bce5fcf270711a2e077fba0fb7c5979ea007eb5 [4] https://bugzilla.redhat.com/show_bug.cgi?id=1746353 [5] https://github.com/gpg/gnupg/blob/f3df8dbb696fed192501fa7f741c2e0e0936a3d5/agent/gpg-agent.c#L1115 [6] https://github.com/gpg/gpgme/blob/52f930c1ed7eee6336a41598c90ef3605b7ed02b/src/engine-gpg.c#L1133
* Remove support for NSSPanu Matilainen2020-05-291-1/+0
| | | | | | | | NSS is a behemoth of a library which drags in a whole runtime subsystem of its own which is often at odds with normal Unix system behavior (hello SIGPIPE). Now that we have nicer alternatives available there's little reason to lug this baggage along. NSS was deprecated in rpm 4.16 (commit 0b9efb93fb38310a48142e2f009740fc5e4abde6).
* Remove support for beecryptPanu Matilainen2020-05-291-1/+0
| | | | | Beecrypt whose upstream is dead for more than ten years now, was deprecated in rpm 4.16 (in commit 0910e6aa9eec7295772c6ad904063f73dd0eb8d6).
* Flush 1998 vintage fcntl-compatibility mess from system.hPanu Matilainen2020-04-021-0/+1
| | | | | fcntl.h is standard, include it from places that need it and drop from system.h.
* Stop adding rpm v3 header+payload signatures by default where not neededPanu Matilainen2020-03-102-7/+18
| | | | | | | | | | | | | | | On packages where a separate payload digest exists (ie those built with rpm >= 4.14), rpm v3 header+payload signatures are nothing but expensive legacy baggage, as the payload digest will be signed by a header-only signature already, without having to recalculate the entire file. Automatically detect the payload digest presence and only add V3 signatures on packages that need it, but also add an override switch to force their addition if needed for compatibility or so. A particular use-case would be ability to signature-level verify the entire package on rpm older than 4.14. Fixes: #863
View Lorry Controller Status