diff options
author | Wayne Davison <wayne@opencoder.net> | 2020-05-22 08:10:41 -0700 |
---|---|---|
committer | Wayne Davison <wayne@opencoder.net> | 2020-05-22 08:27:07 -0700 |
commit | a7303a3d3d1ab3221bcb950f19eefb10e27b4bf7 (patch) | |
tree | 92651ff28fbaaf5e969664ee7743559b6089fcdd | |
parent | 70c6b408dc299f7aa00dd3452ae82b56d6c17f80 (diff) | |
download | rsync-a7303a3d3d1ab3221bcb950f19eefb10e27b4bf7.tar.gz |
Fix a bug in the writing of the batch.sh file
Fix the code that writes the options and the default destination path
into the batch.sh file to be able to handle options being specified
after source/dest args.
-rw-r--r-- | batch.c | 15 | ||||
-rw-r--r-- | main.c | 2 |
2 files changed, 12 insertions, 5 deletions
@@ -213,7 +213,7 @@ static void write_filter_rules(int fd) * understand most of the options, so it uses some overly simple * heuristics to munge the command line into something that will * (hopefully) work. */ -void write_batch_shell_file(int argc, char *argv[], int file_arg_cnt) +void write_batch_shell_file(int argc, char *argv[], int file_argc, char *file_argv[]) { int fd, i, len, err = 0; char *p, *p2, filename[MAXPATHLEN]; @@ -237,8 +237,15 @@ void write_batch_shell_file(int argc, char *argv[], int file_arg_cnt) else write_sbuf(fd, " --exclude-from=-"); } - for (i = 1; i < argc - file_arg_cnt; i++) { + for (i = 1; i < argc; i++) { p = argv[i]; + if (file_argc && p == file_argv[0]) { + if (file_argc > 1) { + file_argv++; + file_argc--; + } + continue; + } if (strncmp(p, "--files-from", 12) == 0 || strncmp(p, "--filter", 8) == 0 || strncmp(p, "--include", 9) == 0 @@ -267,8 +274,8 @@ void write_batch_shell_file(int argc, char *argv[], int file_arg_cnt) err = 1; } } - if (!(p = check_for_hostspec(argv[argc - 1], &p2, &i))) - p = argv[argc - 1]; + if (!(p = check_for_hostspec(file_argv[file_argc - 1], &p2, &i))) + p = file_argv[file_argc - 1]; if (write(fd, " ${1:-", 6) != 6 || write_arg(fd, p) < 0) err = 1; @@ -1726,7 +1726,7 @@ int main(int argc,char *argv[]) if ((write_batch || read_batch) && !am_server) { if (write_batch) - write_batch_shell_file(orig_argc, orig_argv, argc); + write_batch_shell_file(orig_argc, orig_argv, argc, argv); if (read_batch && strcmp(batch_name, "-") == 0) batch_fd = STDIN_FILENO; |