Add rest of windows platforms to be tested on; Fixing syntax issue in build-test-omnibus (#13565)

* Adding rest of windows platforms to test on
* Changing windows platforms to only test 2019 on a default agent in chef-oss; otherwise test everything on the omnibus agents
* Adding key to test steps in pipeline
* Only set secrets on non-test steps
* remove caching plugin
* remove windows 8 from chef-18 pipeline

Signed-off-by: Evan Ahlberg <evanahlberg@gmail.com>

---------

Signed-off-by: Jesse Prieur <jesse.prieur@gmail.com>
Signed-off-by: Evan Ahlberg <evanahlberg@gmail.com>
Co-authored-by: Evan Ahlberg <evanahlberg@gmail.com>

1 files changed, 9 insertions, 9 deletions

diff --git a/.buildkite/verify.pipeline.sh b/.buildkite/verify.pipeline.sh
index c675ab42f6..9e36d2cb6d 100755
--- a/.buildkite/verify.pipeline.sh
+++ b/.buildkite/verify.pipeline.sh
@@ -96,10 +96,10 @@ for gem in ${external_gems[@]}; do
     echo "        - CHEF_FS=true"
   fi
   echo "      propagate-environment: true"
-  echo "  - chef/cache#v1.5.0:"
-  echo "      s3_bucket: core-buildkite-cache-chef-oss-prod"
-  echo "      cached_folders:"
-  echo "      - vendor"
+  # echo "  - chef/cache#v1.5.0:"
+  # echo "      s3_bucket: core-buildkite-cache-chef-oss-prod"
+  # echo "      cached_folders:"
+  # echo "      - vendor"
   echo "  timeout_in_minutes: 60"
   echo "  commands:"
   echo "    - .expeditor/scripts/bk_container_prep.sh"
@@ -153,11 +153,11 @@ for plan in ${habitat_plans[@]}; do
   else
     echo "    queue: single-use-privileged"
   fi
-  echo "  plugins:"
-  echo "  - chef/cache#v1.5.0:"
-  echo "      s3_bucket: core-buildkite-cache-chef-oss-prod"
-  echo "      cached_folders:"
-  echo "      - vendor"
+  # echo "  plugins:"
+  # echo "  - chef/cache#v1.5.0:"
+  # echo "      s3_bucket: core-buildkite-cache-chef-oss-prod"
+  # echo "      cached_folders:"
+  # echo "      - vendor"
   echo "  timeout_in_minutes: 60"
   echo "  commands:"
   if [ $plan == "windows" ]