diff options
| author | danielsdeleo <dan@opscode.com> | 2013-07-05 15:01:31 -0700 |
|---|---|---|
| committer | danielsdeleo <dan@opscode.com> | 2013-07-05 15:26:09 -0700 |
| commit | 07ea110f8694b5b3a36fb936e7eaa46a9ce86050 (patch) | |
| tree | 694bca908e5cd71b6bf66b9e07966959dc025adb /lib/chef/exceptions.rb | |
| parent | 8505ed76e545af010e3d66b2882732fcfffc0084 (diff) | |
| download | chef-07ea110f8694b5b3a36fb936e7eaa46a9ce86050.tar.gz | |
Print debug stacktraces from within a forked worker
Fixes CHEF-4357: http://tickets.opscode.com/browse/CHEF-4357
Rescue exceptions from within a forker worker and feed them to
`Chef::Application.debug_stacktrace()`, then exit non-zero. This fixes
an issue where Chef would spew ruby stacktraces with forking enabled
(stacktraces should only be printed to console with `-l debug`).
Additionally fixes an issue where a generic exception was passed to
`debug_stacktrace`, leaving a stacktrace.out file with no useful
information.
In addition to the above fixes, includes the following improvements:
* Update the forked worker's argv0 to clearly indicate it's the worker
process, and include ppid and run start time.
* When reaping the worker process, include more useful information when
the worker exited non-successfully, such as exit code or signal that
killed the process. In particular, OOM kill (e.g., when running
resource intensive code compile, etc. on small machine) should be a
little more obvious.
Diffstat (limited to 'lib/chef/exceptions.rb')
| -rw-r--r-- | lib/chef/exceptions.rb | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/chef/exceptions.rb b/lib/chef/exceptions.rb index c0a5a185d6..99054eb254 100644 --- a/lib/chef/exceptions.rb +++ b/lib/chef/exceptions.rb @@ -160,6 +160,8 @@ class Chef # the symlink that is there either loops or points to a nonexistent file class InvalidSymlink < RuntimeError; end + class ChildConvergeError < RuntimeError; end + class MissingRole < RuntimeError NULL = Object.new |