Raise an error when including a recipe from an unreachable cookbook

Fixes CHEF-4367.

When attempting to load a recipe belonging to a cookbook that is not in
the run_list or any dependencies of cookbooks in the run_list, chef
will now produce an error like this:

    Chef::Exceptions::MissingCookbookDependency
    -------------------------------------------
    Recipe `ancient::aliens` is not in the run_list, and cookbook 'ancient'
    is not a dependency of any cookbook in the run_list.  To load thisrecipe,
    first add a dependency on cookbook 'ancient' in the cookbook you're
    including it from in that cookbook's metadata.

This error will occur when chef-solo users use `include_recipe` without
specifying the dependency in metadata; prior to this patch, chef would
typically fail reading an undefined attribute, which commonly would
result in a NoMethodError for nil.

1 files changed, 5 insertions, 0 deletions

diff --git a/spec/unit/run_context_spec.rb b/spec/unit/run_context_spec.rb
index 39b8a8a50d..f885f49770 100644
--- a/spec/unit/run_context_spec.rb
+++ b/spec/unit/run_context_spec.rb
@@ -79,6 +79,11 @@ describe Chef::RunContext do
       @node.include_attribute("test::george")
     end
 
+    it "raises an error when attempting to include_recipe from a cookbook not reachable by run list or dependencies" do
+      lambda do
+        @run_context.include_recipe("ancient::aliens")
+      end.should raise_error(Chef::Exceptions::MissingCookbookDependency)
+    end
 
   end