1 files changed, 55 insertions, 7 deletions
diff --git a/chef-server-api/spec/unit/environments_controller_spec.rb b/chef-server-api/spec/unit/environments_controller_spec.rb
index 704a33acfd..5b0391192b 100644
--- a/chef-server-api/spec/unit/environments_controller_spec.rb
+++ b/chef-server-api/spec/unit/environments_controller_spec.rb
@@ -26,17 +26,24 @@ describe "Environments controller" do
     Merb.logger.set_log(StringIO.new)
 
     @env1 = make_environment("env1")
+    
+    @filtered_cookbook_list_env1 = make_filtered_cookbook_hash(make_cookbook("cookbook1", "1.0.0"),
+                                                               make_cookbook("cookbook2", "1.0.0"))
+    @filtered_cookbook_list_env1["cookbook_noversions"] = Array.new
 
-    @filtered_cookbook_list_env1 = 
-      make_filtered_cookbook_hash(make_cookbook("cookbook1", "1.0.0"),
-                                  make_cookbook("cookbook2", "1.0.0"))
-    @filtered_cookbook_list_env2 = 
-      make_filtered_cookbook_hash(make_cookbook("cookbook1", "2.0.0"),
-                                  make_cookbook("cookbook2", "2.0.0"))
+    @filtered_cookbook_list_env2 = make_filtered_cookbook_hash(make_cookbook("cookbook1", "2.0.0"),
+                                                               make_cookbook("cookbook2", "2.0.0"))
+
+    @cookbook_deps_on_nosuch = make_cookbook("cookbook_deps_on_nosuch", "1.0.0")
+    @cookbook_deps_on_nosuch.metadata.depends("cookbook_nosuch")
+
+    @cookbook_deps_on_badver = make_cookbook("cookbook_deps_on_badver", "1.0.0")
+    @cookbook_deps_on_badver.metadata.depends("cookbook1", ">= 3.0.0")
   end
 
   describe "when handling Environments API calls" do
-    it "should expand the passed-in run_list using the correct environment" do
+    it "should expand the passed-in run_list using the correct environment: one run_list item" do
+
       # Env1 pins both versions at 1.0.0. Expect only the one we ask for, cookbook1,
       # back in the result.
       Chef::Environment.should_receive(:cdb_load_filtered_cookbook_versions).with("env1").and_return(@filtered_cookbook_list_env1)
@@ -46,7 +53,9 @@ describe "Environments controller" do
       response["cookbook1"].should_not == nil
       response["cookbook1"]['version'].should == "1.0.0"
       response["cookbook1"]['url'].should == "#{root_url}/cookbooks/cookbook1/1.0.0"
+    end
 
+    it "should expect the passed-in run_list using the correct environment: two run_list items" do
       # Ask for both cookbook1 and cookbook2 back. Expect version 2.0.0 for
       # each, as those are what's appropriate for the environment.
       Chef::Environment.should_receive(:cdb_load_filtered_cookbook_versions).with("env2").and_return(@filtered_cookbook_list_env2)
@@ -60,6 +69,45 @@ describe "Environments controller" do
       response["cookbook2"]['version'].should == "2.0.0"
       response["cookbook2"]['url'].should == "#{root_url}/cookbooks/cookbook2/2.0.0"
     end
+
+    it "should report no_such_cookbook if given a dependency on a non-existant cookbook" do
+      Chef::Environment.should_receive(:cdb_load_filtered_cookbook_versions).with("env1").and_return(@filtered_cookbook_list_env1)
+      expected_error = {
+        "message" => "Run list item (cookbook_nosuch >= 0.0.0) specifies a cookbook that does not exist in the dependency graph",
+      }.to_json
+
+      lambda {
+        response = post_json("/environments/env1/cookbook_versions", {"run_list" => ["recipe[cookbook_nosuch]"]})
+      }.should raise_error(Merb::ControllerExceptions::PreconditionFailed, expected_error)
+    end
+
+    it "should report no_such_version if given a dependency on a cookbook that doesn't have any valid versions for an environment" do
+      Chef::Environment.should_receive(:cdb_load_filtered_cookbook_versions).with("env1").and_return(@filtered_cookbook_list_env1)
+      expected_error = {
+        "message" => "Run list item (cookbook_noversions >= 0.0.0) does not match any versions",
+      }.to_json
+
+      lambda {
+        response = post_json("/environments/env1/cookbook_versions", {"run_list" => ["recipe[cookbook_noversions]"]})
+      }.should raise_error(Merb::ControllerExceptions::PreconditionFailed, expected_error)
+    end
+
+
+    # TODO; have top-level cookbooks depend on other, non-existent cookbooks,
+    # to get the other kind of exceptions.
+    it "should report multiple failures (compound exceptions) if there is more than one error in dependencies" do
+      Chef::Environment.should_receive(:cdb_load_filtered_cookbook_versions).with("env1").and_return(@filtered_cookbook_list_env1)
+      begin
+        response = post_json("/environments/env1/cookbook_versions", 
+                             {"run_list" => ["recipe[cookbook_nosuch_1]", "recipe[cookbook_nosuch_2]"]})
+      rescue => e
+        puts "e is #{e}"
+        puts "e.stacktrace =\n  #{e.backtrace.join("  \n")}"
+
+        require 'pp'
+        pp(:e => e)
+      end
+    end
   end
 end