| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
* Add a case-insensitive helper to determine if two checksums match
* Use case-insensitive checksum match helper for checksum validation
This fixes a bug where checksum validation fails because the two
checksums are in different letter cases. The existing checksum
validation logic was using case sensitive equality checks.
Signed-off-by: Joseph Larionov <jlarionov@webmd.net>
|
|
|
|
|
|
| |
Now that knife has been moved we can resolve the current warnings
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: mwrock <matt@mattwrock.com>
|
|
|
|
|
|
|
| |
I didn't realize that the source_package was being used to
collect the merged state off of the property.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
|
|
|
|
| |
Signed-off-by: Pete Higgins <pete@peterhiggins.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
| |
Remove the overriding of the action block entirely and clean up some
overly complicated code.
In the process it looks like the "unknown" version codepath is blatantly
entirely unused, so it was removed. A bunch of extra unnecessary
indirection was also removed.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
| |
Legally incredibly dubious, particularly since we don't follow it
strictly as policy, and we have git history instead, which does it right.
This is just a waste of time and a cargo cult.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
| |
May be a potentially breaking change if I noodle hard enough on it, it
does mean that all the actions are now (correctly) encapsulated in a
sub-resource collection, whereas before they never had one.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
| |
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
| |
This gives a speed boost since rubygems does not have to scan through
every gem in the gemset in order to find the file.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
| |
confusing use case is very confusing.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
| |
the windows package provider is doing some very strange, and very likely
very buggy things.
i don't have the time or the knowledge right now to unwind these though.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|\
| |
| | |
windows_package: Fix package sensitive error
|
| |
| |
| |
| | |
Signed-off-by: dheerajd-msys <dheeraj.dubey@msystechnologies.com>
|
| |
| |
| |
| |
| |
| | |
I noticed we weren't using the package_name name property in most of our why-run or logging messages in various package providers. This would lead to some pretty confusing log output when using the name property.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|/
|
|
| |
Signed-off-by: Josh Barker <josh.barker.developer@gmail.com>
|
|
|
|
| |
Signed-off-by: Josh Barker <josh.barker.developer@gmail.com>
|
|
|
|
| |
Signed-off-by: Thom May <thom@chef.io>
|
|
|
|
|
|
| |
We need to rethink this spec. The 1:1 mapping stuff doesn't seem like it has a lot of value. The portion below where we test 1:many mappings seem to be the value. I want to know the right thing mapped to package, service, or user on Debian XYZ.
Signed-off-by: Tim Smith <tsmith@chef.io>
|
|
|
|
| |
Signed-off-by: Jon Cowie <jcowie@chef.io>
|
|
|
|
|
|
| |
Some windows package managers use the version string "latest" - when this happens, have version_compare always return 0, as we can't reliably tell what version number we're looking at.
Signed-off-by: Jon Cowie <jcowie@chef.io>
|
|
|
|
|
|
|
|
|
| |
- cleans up a lot of ivar usage
- converts most providers to shell_out_compact_timeout!
- almost deprecates a few APIs, but can't quite yet
- windows providers need mixlib-shellout to take an argv
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently rubocop thinks the default behavior should be that we have to
rewrite every use of `foo == 0` into `foo.zero?` which is a big pile of
NOPE for me. After discovering that `.zero?` is actually slower, I'd
prefer to go the other direction. Same for `positive?` and
`negative?`.
These are the only uses of `zero?` in the chef/chef codebase, while I'm
pretty sure the inverse rule would touch nearly every file.
Signed-off-by: Lamont Granquist <lamont@scriptkiddie.org>
|
|
|
|
|
|
|
|
|
|
| |
windows_package resource. (#5332)
* Fixed undefined short_cksum method issue and checksum in uppercase issue for windows_package resource.
* Added RSpecs for the changes done here.
* Fixed RSpecs issues.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Style/NegatedWhile
Style/ParenthesesAroundCondition
Style/WhileUntilDo
Style/WordArray
Performance/ReverseEach
Style/ColonMethodCall
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
4174 Style/SpaceInsideHashLiteralBraces
1860 Style/SpaceAroundOperators
1336 Style/SpaceInsideBlockBraces
1292 Style/AlignHash
997 Style/SpaceAfterComma
860 Style/SpaceAroundEqualsInParameterDefault
310 Style/EmptyLines
294 Style/IndentationConsistency
267 Style/TrailingWhitespace
238 Style/ExtraSpacing
212 Style/SpaceBeforeBlockBraces
166 Style/MultilineOperationIndentation
144 Style/TrailingBlankLines
120 Style/EmptyLineBetweenDefs
101 Style/IndentationWidth
82 Style/SpaceAroundBlockParameters
40 Style/EmptyLinesAroundMethodBody
29 Style/EmptyLinesAroundAccessModifier
1 Style/RescueEnsureAlignment
|
|
|
| |
Generated via git ls-files | xargs perl -pi -e "s/[Cc]opyright (?:\([Cc]\) )?((?\!$(date +%Y))\\d{4})(-\\d{4})?([, ][ \d]+)*(,|(?= ))/Copyright \\1-$(date +%Y),/g"
|
|
|
|
|
|
|
| |
This is an entirely mechanically generated (chefstyle -a) change, to go
along with chef/chefstyle#5 . We should pick something and use it
consistently, and my opinion is that double quotes are the appropriate
thing.
|
|
|
|
| |
Style/SignalException - 3
|
|
|
|
|
|
|
|
|
| |
fixes the following offenses:
46 Lint/EndAlignment
21 Lint/BlockAlignment
3 Lint/SpaceBeforeFirstArg
1 Lint/DefEndAlignment
|
| |
|
| |
|
| |
|
|
|
|
| |
windows_package resource
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
| |
new dynamic provider resolver.
|
| |
|
|
Adds the framework for a windows package provider, which must determine the
correct provider by examining metadata about the source file, or the source
file itself.
Provides FFI based access to the Windows Installer functions to retrieve
metadata from the MSI files and from the Windows product database.
Combines both of these into an MSI package provider.
Continues to work alongside the windows_package LWRP.
|