summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJaymala Sinha <jsinha@chef.io>2019-10-14 12:56:12 -0400
committerJaymala Sinha <jsinha@chef.io>2019-10-14 12:56:12 -0400
commit6b53b70c67a5e4cb29b66d5765f182c46c8732d3 (patch)
treefd30bd64a6bf1b33c2d5a94af790604bf6e0f0a6
parent87e09a420860ef9f708b7501ff29ab1223154ce3 (diff)
downloadffi-yajl-6b53b70c67a5e4cb29b66d5765f182c46c8732d3.tar.gz
Address review comments
Signed-off-by: Jaymala Sinha <jsinha@chef.io>
-rw-r--r--.expeditor/config.yml2
-rw-r--r--.expeditor/verify.pipeline.yml2
-rw-r--r--Gemfile8
3 files changed, 4 insertions, 8 deletions
diff --git a/.expeditor/config.yml b/.expeditor/config.yml
index ae7f111..62e9610 100644
--- a/.expeditor/config.yml
+++ b/.expeditor/config.yml
@@ -7,7 +7,7 @@ slack:
# This publish is triggered by the `built_in:publish_rubygems` artifact_action.
rubygems:
- ffi-yajl
- - ffi-yajl-universla-java
+ - ffi-yajl-universal-java
github:
# This deletes the GitHub PR branch after successfully merged into the release branch
diff --git a/.expeditor/verify.pipeline.yml b/.expeditor/verify.pipeline.yml
index 1445e83..06ca2f3 100644
--- a/.expeditor/verify.pipeline.yml
+++ b/.expeditor/verify.pipeline.yml
@@ -6,7 +6,7 @@ steps:
- ruby --version
- bundle --version
- gem update --system
- - bundle install --without development_extras development --jobs 3 --retry 3 --path vendor/bundle
+ - bundle install --without development_extras --jobs 3 --retry 3 --path vendor/bundle
- gem install yajl-ruby json psych
- bundle exec rake
soft_fail:
diff --git a/Gemfile b/Gemfile
index d0a7640..352df49 100644
--- a/Gemfile
+++ b/Gemfile
@@ -2,11 +2,6 @@ source "https://rubygems.org"
gemspec name: "ffi-yajl"
-group :test do
- gem "rspec"
- gem "rake-compiler"
-end
-
platforms :rbx do
gem "rubysl", "~> 2.0"
end
@@ -14,7 +9,8 @@ end
group :development do
# for testing loading concurrently with yajl-ruby, not on jruby
# gem 'yajl-ruby', platforms: [ :ruby, :mswin, :mingw ]
- gem "github_changelog_generator"
+ gem "rspec"
+ gem "rake-compiler"
end
group :development_extras do