Switch from reek/rubocop to chefstyle

Reek doesn't work with modern Rake

Signed-off-by: Tim Smith <tsmith@chef.io>

1 files changed, 48 insertions, 93 deletions

diff --git a/Rakefile b/Rakefile
index 05a69d1..331b3fd 100644
--- a/Rakefile
+++ b/Rakefile
@@ -1,10 +1,10 @@
 $LOAD_PATH << File.expand_path(File.join(File.dirname( __FILE__ ), "lib"))
 
-require 'rspec/core/rake_task'
-require 'rubygems/package_task'
-require 'rake/extensiontask'
-require 'ffi_yajl/version'
-require 'github_changelog_generator/task'
+require "rspec/core/rake_task"
+require "rubygems/package_task"
+require "rake/extensiontask"
+require "ffi_yajl/version"
+require "github_changelog_generator/task"
 
 Dir[File.expand_path("../*gemspec", __FILE__)].reverse_each do |gemspec_path|
   gemspec = eval(IO.read(gemspec_path))
@@ -13,7 +13,7 @@ end
 
 GitHubChangelogGenerator::RakeTask.new :changelog do |config|
   config.issues = false
-  config.since_tag = '1.0.1'
+  config.since_tag = "1.0.1"
   config.exclude_labels = %w{duplicate question invalid wontfix changelog_skip}
 end
 
@@ -42,26 +42,26 @@ task install: [:package] do
   end
 end
 
-spec = Gem::Specification.load('ffi-yajl.gemspec')
+spec = Gem::Specification.load("ffi-yajl.gemspec")
 
 Rake::ExtensionTask.new do |ext|
-  ext.name = 'encoder'
-  ext.lib_dir = 'lib/ffi_yajl/ext'
-  ext.ext_dir = 'ext/ffi_yajl/ext/encoder'
+  ext.name = "encoder"
+  ext.lib_dir = "lib/ffi_yajl/ext"
+  ext.ext_dir = "ext/ffi_yajl/ext/encoder"
   ext.gem_spec = spec
 end
 
 Rake::ExtensionTask.new do |ext|
-  ext.name = 'parser'
-  ext.lib_dir = 'lib/ffi_yajl/ext'
-  ext.ext_dir = 'ext/ffi_yajl/ext/parser'
+  ext.name = "parser"
+  ext.lib_dir = "lib/ffi_yajl/ext"
+  ext.ext_dir = "ext/ffi_yajl/ext/parser"
   ext.gem_spec = spec
 end
 
 Rake::ExtensionTask.new do |ext|
-  ext.name = 'dlopen'
-  ext.lib_dir = 'lib/ffi_yajl/ext'
-  ext.ext_dir = 'ext/ffi_yajl/ext/dlopen'
+  ext.name = "dlopen"
+  ext.lib_dir = "lib/ffi_yajl/ext"
+  ext.ext_dir = "ext/ffi_yajl/ext/dlopen"
   ext.gem_spec = spec
 end
 
@@ -80,101 +80,56 @@ end
 namespace :spec do
   desc "Run all specs against ffi extension"
   RSpec::Core::RakeTask.new(:ffi) do |t|
-    ENV['FORCE_FFI_YAJL'] = "ffi"
-    t.pattern = FileList['spec/**/*_spec.rb']
+    ENV["FORCE_FFI_YAJL"] = "ffi"
+    t.pattern = FileList["spec/**/*_spec.rb"]
   end
   if !defined?(RUBY_ENGINE) || RUBY_ENGINE !~ /jruby/
     desc "Run all specs again c extension"
     RSpec::Core::RakeTask.new(:ext) do |t|
-      ENV['FORCE_FFI_YAJL'] = "ext"
-      t.pattern = FileList['spec/**/*_spec.rb']
+      ENV["FORCE_FFI_YAJL"] = "ext"
+      t.pattern = FileList["spec/**/*_spec.rb"]
     end
   end
 end
 
-if RUBY_VERSION.to_f >= 1.9
-  namespace :integration do
-    begin
-      require 'kitchen'
-    rescue LoadError
-      task :vagrant do
-        puts "test-kitchen gem is not installed"
-      end
-      task :cloud do
-        puts "test-kitchen gem is not installed"
-      end
-    else
-      desc 'Run Test Kitchen with Vagrant'
-      task :vagrant do
-        Kitchen.logger = Kitchen.default_file_logger
-        Kitchen::Config.new.instances.each do |instance|
-          instance.test(:always)
-        end
-      end
-
-      desc 'Run Test Kitchen with cloud plugins'
-      task :cloud do
-        if ENV['TRAVIS_PULL_REQUEST'] != 'true'
-          ENV['KITCHEN_YAML'] = '.kitchen.cloud.yml'
-          sh "kitchen test --concurrency 4"
-        end
-      end
-    end
-  end
-  namespace :style do
-    desc 'Run Ruby style checks'
-    begin
-      require 'rubocop/rake_task'
-    rescue LoadError
-      task :rubocop do
-        puts "rubocop gem is not installed"
-      end
-    else
-      RuboCop::RakeTask.new(:rubocop) do |t|
-        t.fail_on_error = false
-      end
-    end
-
-    desc 'Run Ruby smell checks'
-    begin
-      require 'reek/rake/task'
-    rescue LoadError
-      task :reek do
-        puts "reek gem is not installed"
-      end
-    else
-      Reek::Rake::Task.new(:reek) do |t|
-        t.fail_on_error = false
-        #        t.config_files = '.reek.yml'
-      end
-    end
-  end
-else
-  namespace :integration do
+namespace :integration do
+  begin
+    require "kitchen"
+  rescue LoadError
     task :vagrant do
-      puts "test-kitchen unsupported on ruby 1.8"
+      puts "test-kitchen gem is not installed"
     end
-    task :cloud do
-      puts "test-kitchen unsupported on ruby 1.8"
+  else
+    desc "Run Test Kitchen with Vagrant"
+    task :vagrant do
+      Kitchen.logger = Kitchen.default_file_logger
+      Kitchen::Config.new.instances.each do |instance|
+        instance.test(:always)
+      end
     end
   end
-  namespace :style do
+end
+namespace :style do
+  desc "Run Ruby style checks"
+  begin
+    require "chefstyle"
+    require "rubocop/rake_task"
+  rescue LoadError
     task :rubocop do
-      puts "rubocop unsupported on ruby 1.8"
+      puts "chefstyle gem is not installed"
     end
-    task :reek do
-      puts "reek unsupported on ruby 1.8"
+  else
+    RuboCop::RakeTask.new(:rubocop) do |t|
+      t.fail_on_error = false
     end
   end
 end
 
-desc 'Run all style checks'
-task style: ['style:rubocop', 'style:reek']
+desc "Run all style checks"
+task style: ["style:rubocop"]
 
-desc 'Run style + spec tests by default on travis'
+desc "Run style + spec tests by default on travis"
 task travis: %w{style spec}
 
-desc 'Run style, spec and test kichen on travis'
-task travis_all: ['style', 'spec', 'integration:cloud']
-
-task default: ['style', 'spec', 'integration:vagrant']
+desc "Run style + spec tests by default"
+task default: %w{style spec}