Make Dash greedier when creating getters

Dash, in its current form, was created to be very conservative in
creating the getters for its properties. It only creates them when the
accompanying setter has not already been created. This means that the
property translation capability that is layered on top of Dash to create
a Trash cannot have dependence between properties in an
order-independent way.

This change makes it so Dash now greedily creates a getter method for
each property. To ensure that we don't do this more than once for
a given Dash class, we track the getters we have previously created.
This keeps the number of warnings from Ruby down to the same number of
warnings that were emitted prior to this change.

Given that Dash users expect the getter to be set, this doesn't feel
like it should cause any backwards-compatibility issues.

1 files changed, 12 insertions, 0 deletions

diff --git a/spec/hashie/trash_spec.rb b/spec/hashie/trash_spec.rb
index a5e5d02..043cbfd 100644
--- a/spec/hashie/trash_spec.rb
+++ b/spec/hashie/trash_spec.rb
@@ -312,5 +312,17 @@ describe Hashie::Trash do
       expect(subject.to_h[:value]).to eq(nil)
       expect(subject.copy_of_value).to eq(0)
     end
+
+    it 'is not order-dependent in definition' do
+      simple = Class.new(Hashie::Trash) do
+        property :copy_of_id, from: :id
+        property :id
+      end
+
+      subject = simple.new(id: 1)
+
+      expect(subject.id).to eq(1)
+      expect(subject.copy_of_id).to eq(1)
+    end
   end
 end