summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #263 from JEG2/release_3_0_0_pre_1HEADv3.0.0.pre.1masterAbinoam P. Marques Jr2023-04-274-12/+12
|\ | | | | Release 3.0.0.pre.1
| * Remove unsupported rubies from ci.ymlrelease_3_0_0_pre_1Abinoam P. Marques Jr2023-04-271-5/+0
| |
| * Update changelogAbinoam P. Marques Jr2023-04-271-5/+10
| |
| * Bump up version to 3.0.0.pre.1Abinoam P. Marques Jr2023-04-271-1/+1
| |
| * Raise Ruby version requirement to 3.0Abinoam P. Marques Jr2023-04-271-1/+1
|/ | | | | | | | | | | | Ruby 2.7 is tagged End of Life (not even security maintanence) since this month. We (Highline) traditionally try to maintain compatibility with old rubies. But rubies bellow 2.7.1 lack "io/console" or they have incompatibilities. (as discussed in PR #259) So, this EOL of 2.7 signal to us that is time for us to move on. People relying on old versions of Highline will probably face no problem with it. But we will be free to start removing old code that is necessary only for retrocompatibility in newer versions.
* Merge pull request #262 from kbrock/silent_ttyAbinoam P. Marques Jr2023-04-252-5/+7
|\ | | | | Do not call stty on non-tty
| * Do not call stty on non-ttyKeenan Brock2023-04-242-3/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When testing on a non-tty (e.g.: github actions), either one of these lines produces an error: ```ruby input.echo = true ask("question", "y") { |q| q.readline = true } ``` The error is produced by ruby internals: ```bash echo | rake | cat ......stty: stdin isn't a terminal...... ``` This change skips the stty calls if the input is not on a tty, so the errors will not be produced.
| * Use existing save_stty functionalityKeenan Brock2023-04-241-2/+2
|/ | | | | Yes, `save_stty` and `restore_stty` should probably not live in terminal, but they do. No reason to re-implement them. And they handle error cases better.
* Merge pull request #260 from abinoam/issue_43Abinoam P. Marques Jr2023-01-072-0/+41
|\ | | | | Fix #43 - Ctrl-U (erase line) handling
| * Add tests for Ctrl-U (erase line) handlingAbinoam P. Marques Jr2023-01-061-0/+38
| |
| * Fix #43 - Handle erase line correctly (CTRL-U)Abinoam P. Marques Jr2023-01-061-0/+3
|/
* Merge pull request #259 from abinoam/issue_236Abinoam P. Marques Jr2023-01-064-2/+17
|\ | | | | Handle Ctrl-C when Question#echo = false (raw_no_echo_mode)
| * Add test for raise interrupt with ctrl-cAbinoam P. Marques Jr2023-01-061-0/+14
| |
| * Update IOConsoleCompatible#getch to io/console signatureAbinoam P. Marques Jr2023-01-051-1/+1
| |
| * Handle interrupts directly at io/consoleAbinoam P. Marques Jr2023-01-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Added to io/console at commit at 24, September, 2019 * https://github.com/ruby/io-console/commit/7cba76561a39722fbcee3a65d4d6b8bc6f15df67 Released in Ruby 2.7.0, released at 25, December, 2019 * https://www.ruby-lang.org/en/news/2019/12/25/ruby-2-7-0-released/ Documented at 17, February, 2020 * https://github.com/ruby/io-console/commit/82b630cd79594339d4b05ebe211f47d62dbe1fc5 Documented in Ruby 2.7.1, released at 31, March, 2020 * https://ruby-doc.org/stdlib-2.7.1/libdoc/io/console/rdoc/IO.html#method-i-getch * https://www.ruby-lang.org/en/news/2020/03/31/ruby-2-7-1-released/
| * Handle Ctrl-C when Question#echo = false (raw_no_echo_mode)Faheetah2023-01-041-0/+1
|/
* Merge pull request #258 from abinoam/issue_246Abinoam P. Marques Jr2023-01-026-2/+126
|\ | | | | Issue #246 - Add custom validation class option to `Question#validate`
| * Update Changelog.mdAbinoam P. Marques Jr2023-01-021-1/+5
| |
| * Add custom parser / custom validation exampleAbinoam P. Marques Jr2023-01-021-0/+39
| |
| * Update Question#validate inline documentationAbinoam P. Marques Jr2023-01-021-0/+3
| |
| * Document custom class validation in ReadmeAbinoam P. Marques Jr2023-01-021-0/+27
| |
| * Add test for the new validation class featureAbinoam P. Marques Jr2023-01-021-0/+49
| |
| * Add dry-types dependencyAbinoam P. Marques Jr2023-01-021-0/+1
| |
| * Enable using a validator class for validationAbinoam P. Marques Jr2023-01-021-1/+2
|/
* Merge pull request #257 from abinoam/issue_233Abinoam P. Marques Jr2023-01-014-7/+60
|\ | | | | Issue #233 - Show Question#default value hint for non String objects
| * Update Changelog.mdAbinoam P. Marques Jr2023-01-011-0/+4
| |
| * Document the new Question#default_hint_showAbinoam P. Marques Jr2023-01-013-6/+40
| |
| * Add test for issue #233Abinoam P. Marques Jr2023-01-011-1/+16
|/ | | | Show default for non Strings
* Merge pull request #256 from abinoam/issue_249Abinoam P. Marques Jr2023-01-013-5/+22
|\ | | | | Fix #249 - Question#in convert and check_range
| * Disentangle check_range stepAbinoam P. Marques Jr2022-12-312-2/+2
| |
| * Check_range even if it's not being convertedAbinoam P. Marques Jr2022-12-311-3/+1
| |
| * Add test for issue #249Abinoam P. Marques Jr2022-12-311-0/+19
|/
* Merge pull request #255 from abinoam/release_2_1_0v2.1.0Abinoam P. Marques Jr2022-12-315-41/+9
|\ | | | | Release 2.1.0
| * Remove AppVeyor badge and fileAbinoam P. Marques Jr2022-12-312-38/+0
| | | | | | | | Because we're testing Windows with GitHub Actions.
| * Remove Travis badge and add GitHub Actions badgeAbinoam P. Marques Jr2022-12-311-1/+1
| |
| * Update Changelog.mdAbinoam P. Marques Jr2022-12-311-0/+6
| |
| * Bump up version to 2.1.0Abinoam P. Marques Jr2022-12-311-1/+1
| |
| * Bump up required ruby versionAbinoam P. Marques Jr2022-12-311-1/+1
|/ | | | To reflect the Ruby versions we are testing against.
* Merge pull request #254 from abinoam/experiment_with_github_actionsAbinoam P. Marques Jr2022-12-312-10/+26
|\ | | | | Add MacOs, Windows, TruffleRuby and head branches to the GH Actions matrix
| * Remove platform restriction for simplecovAbinoam P. Marques Jr2022-12-311-4/+1
| |
| * Temporarily remove pronto-poper because of incompatibilityAbinoam P. Marques Jr2022-12-311-0/+1
| | | | | | | | Let it commented out as a reminder.
| * Add MacOS and Windows to the test matrixAbinoam P. Marques Jr2022-12-311-0/+15
| |
| * Runs GH Actions from an OS matrixAbinoam P. Marques Jr2022-12-311-2/+2
| | | | | | | | So we include Mac and Windows to it.
| * Add more Ruby versions to GitHub Actions matrixAbinoam P. Marques Jr2022-12-311-4/+7
|/
* Merge pull request #253 from petergoldstein/feature/add_ruby_3_2_to_ciAbinoam P. Marques Jr2022-12-312-2/+2
|\ | | | | Add Ruby 3.2 to the CI matrix
| * Remove pronto-poper dependencyPeter Goldstein2022-12-311-1/+0
| |
| * Adds Ruby 3.2 to the CI matrix. Also update checkout action version.Peter Goldstein2022-12-291-1/+2
|/
* Remove Ruby 2.0, since rugged no longer builds with itPeter Goldstein2022-12-291-1/+0
|
* Remove .travis.ymlPeter Goldstein2022-12-291-43/+0
|
* Make test task specific, add a few more rubiesPeter Goldstein2022-12-291-2/+7
|