Fix booleans without validate_type with arguments

If we're not using `validate_type`, we shouldn't try to check a boolean
flag's argument to check if it's valid (actually, we probably shouldn't
even do that WITH using `validate_type`, but that's a separate issue).

For now, this will prevent broken boolean flags.

Fixes #279

2 files changed, 12 insertions, 0 deletions

diff --git a/lib/slop/types.rb b/lib/slop/types.rb
index a08537d..d68fe76 100644
--- a/lib/slop/types.rb
+++ b/lib/slop/types.rb
@@ -26,6 +26,11 @@ module Slop
     VALID_VALUES = (FALSE_VALUES + TRUE_VALUES).freeze
 
     def valid?(value)
+      # If we don't want to validate the type, then we don't care if the value
+      # is valid or not. Otherwise we would prevent boolean flags followed by
+      # arguments from being parsed correctly.
+      return true unless config[:validate_type]
+
       return true if value.is_a?(String) && value.start_with?("--")
       value.nil? || VALID_VALUES.include?(value)
     end
diff --git a/test/types_test.rb b/test/types_test.rb
index c6f0864..05e6265 100644
--- a/test/types_test.rb
+++ b/test/types_test.rb
@@ -66,6 +66,13 @@ describe Slop::BoolOption do
       @result.parser.parse %w(--verbose foo)
     end
   end
+
+  # Like above but without validate_type
+  it "returns true if used and ignores the value" do
+    @result.parser.parse %w(--quiet foo)
+
+    assert_equal true, @result[:quiet]
+  end
 end
 
 describe Slop::IntegerOption do