diff options
author | 卜部昌平 <shyouhei@ruby-lang.org> | 2020-06-16 10:52:30 +0900 |
---|---|---|
committer | 卜部昌平 <shyouhei@ruby-lang.org> | 2020-06-29 11:05:41 +0900 |
commit | 60212cd8eef55b1b3c4482dfd0c65d2151cb2d30 (patch) | |
tree | 729929060c3d59341fd416240d789f99bc61245a /object.c | |
parent | 3b8d9badab0433e3022c2d423c3f53b00de634d7 (diff) | |
download | ruby-60212cd8eef55b1b3c4482dfd0c65d2151cb2d30.tar.gz |
rb_mod_const_defined: do not goto into a branch
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea. Better refactor.
Diffstat (limited to 'object.c')
-rw-r--r-- | object.c | 6 |
1 files changed, 4 insertions, 2 deletions
@@ -2676,8 +2676,7 @@ rb_mod_const_defined(int argc, VALUE *argv, VALUE mod) pend = path + RSTRING_LEN(name); if (p >= pend || !*p) { - wrong_name: - rb_name_err_raise(wrong_constant_name, mod, name); + goto wrong_name; } if (p + 2 < pend && p[0] == ':' && p[1] == ':') { @@ -2750,6 +2749,9 @@ rb_mod_const_defined(int argc, VALUE *argv, VALUE mod) } return Qtrue; + + wrong_name: + rb_name_err_raise(wrong_constant_name, mod, name); } /* |