diff options
author | Yusuke Endoh <mame@ruby-lang.org> | 2022-01-04 23:18:34 +0900 |
---|---|---|
committer | git <svn-admin@ruby-lang.org> | 2022-01-04 23:18:37 +0900 |
commit | e9a4cc02b491fc8a2936f51b9f94ddcd77dd67f7 (patch) | |
tree | 144076b345bf9b9dfd895a53b67dcd6ebac859d6 /test/error_highlight | |
parent | 11b1ebe606a82bcdcb4ff5568f0302c5470d0048 (diff) | |
download | ruby-e9a4cc02b491fc8a2936f51b9f94ddcd77dd67f7.tar.gz |
[ruby/error_highlight] Add a test to check if it is robust against a spoofed filename
Previously, RubyVM::AST.of opened a wrong file if the iseq's file path is spoofed.
```
module Dummy
binding.irb
end
```
```
$ ruby test.rb
From: test.rb @ line 2 :
1: module Dummy
=> 2: binding.irb
3: end
irb(Dummy):001:0> foo
/home/mame/work/ruby/local/lib/ruby/3.1.0/error_highlight/base.rb:412:in `spot_colon2': undefined method `last_lineno' for nil:NilClass (NoMethodError)
if nd_parent.last_lineno == @node.last_lineno
^^^^^^^^^^^^
```
Found by @kateinoigakukun
This issue is already fixed in the interpreter side.
This change just adds a test for the case.
https://github.com/ruby/error_highlight/commit/f3626b9032
Diffstat (limited to 'test/error_highlight')
-rw-r--r-- | test/error_highlight/test_error_highlight.rb | 17 |
1 files changed, 17 insertions, 0 deletions
diff --git a/test/error_highlight/test_error_highlight.rb b/test/error_highlight/test_error_highlight.rb index d31e394e78..a3cc7aa149 100644 --- a/test/error_highlight/test_error_highlight.rb +++ b/test/error_highlight/test_error_highlight.rb @@ -1207,4 +1207,21 @@ undefined method `foo' for nil:NilClass end end + def test_spoofed_filename + Tempfile.create(["error_highlight_test", ".rb"], binmode: true) do |tmp| + tmp << "module Dummy\nend\n" + tmp.close + + assert_error_message(NameError, <<~END) do + undefined local variable or method `foo' for "dummy":String + END + + "dummy".instance_eval do + eval <<-END, nil, tmp.path + foo + END + end + end + end + end end |