diff options
author | Yusuke Endoh <mame@ruby-lang.org> | 2021-06-02 12:32:47 +0900 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2021-06-03 12:23:22 +0900 |
commit | b957c3dbcb3cfee6908f4217cfb9ab0e78b4c618 (patch) | |
tree | bec7fb72365a4f9389eead36a20de848f2fb716f /test/rubygems/test_gem_commands_specification_command.rb | |
parent | 28b481938b5c8211aad53ba82fe4ddd978ffc00f (diff) | |
download | ruby-b957c3dbcb3cfee6908f4217cfb9ab0e78b4c618.tar.gz |
[rubygems/rubygems] Rename test/rubygems/test_{case,utilities}.rb to avoid "test_" prefix
This changes "test/rubygems/test_case.rb" to "test/rubygems/helper.rb",
and "test/rubygems/test_utilities.rb" to "test/rubygems/utilities.rb".
The two files are a helper for tests, not test files. However, a file
starting with "test_" prefix is handled as a test file directly loaded
by test-unit because Rakefile specifies:
```
t.test_files = FileList['test/**/test_*.rb']
```
Directly loading test/rubygems/test_utilities.rb caused "uninitialized
constant Gem::TestCase". This issue was fixed by
59c682097197fee4052b47e4b4ab86562f3eaa9b, but the fix caused a
"circular require" warning because test_utilities.rb and test_case.rb
are now requiring each other.
Anyway, adding "test_" prefix to a test helper file is confusing, so
this changeset reverts the fix and solve the issue by renaming them.
https://github.com/rubygems/rubygems/commit/6460e018df
Diffstat (limited to 'test/rubygems/test_gem_commands_specification_command.rb')
-rw-r--r-- | test/rubygems/test_gem_commands_specification_command.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/rubygems/test_gem_commands_specification_command.rb b/test/rubygems/test_gem_commands_specification_command.rb index 106a32a28e..c8cb7df32e 100644 --- a/test/rubygems/test_gem_commands_specification_command.rb +++ b/test/rubygems/test_gem_commands_specification_command.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true -require_relative 'test_case' +require_relative 'helper' require 'rubygems/commands/specification_command' class TestGemCommandsSpecificationCommand < Gem::TestCase |