diff options
author | Jeremy Evans <code@jeremyevans.net> | 2019-09-20 19:06:22 -0700 |
---|---|---|
committer | Jeremy Evans <code@jeremyevans.net> | 2019-11-18 01:00:25 +0200 |
commit | c5c05460ac20abcbc0ed686eb4acf06da7a39a79 (patch) | |
tree | 991109a68f3b1cd2e256a936701d3b2badd3ddac /test/test_tmpdir.rb | |
parent | 7b6a8b5b54448235e17ed187d9d73f56893e1b6f (diff) | |
download | ruby-c5c05460ac20abcbc0ed686eb4acf06da7a39a79.tar.gz |
Warn on access/modify of $SAFE, and remove effects of modifying $SAFE
This removes the security features added by $SAFE = 1, and warns for access
or modification of $SAFE from Ruby-level, as well as warning when calling
all public C functions related to $SAFE.
This modifies some internal functions that took a safe level argument
to no longer take the argument.
rb_require_safe now warns, rb_require_string has been added as a
version that takes a VALUE and does not warn.
One public C function that still takes a safe level argument and that
this doesn't warn for is rb_eval_cmd. We may want to consider
adding an alternative method that does not take a safe level argument,
and warn for rb_eval_cmd.
Diffstat (limited to 'test/test_tmpdir.rb')
-rw-r--r-- | test/test_tmpdir.rb | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/test/test_tmpdir.rb b/test/test_tmpdir.rb index 42bcbc00a8..c599dcf516 100644 --- a/test/test_tmpdir.rb +++ b/test/test_tmpdir.rb @@ -11,19 +11,6 @@ class TestTmpdir < Test::Unit::TestCase assert_equal(tmpdir_org, Dir.tmpdir) end - def test_tmpdir_modifiable_safe - Thread.new { - $SAFE = 1 - tmpdir = Dir.tmpdir - assert_equal(false, tmpdir.frozen?) - tmpdir_org = tmpdir.dup - tmpdir << "foo" - assert_equal(tmpdir_org, Dir.tmpdir) - }.join - ensure - $SAFE = 0 - end - def test_world_writable skip "no meaning on this platform" if /mswin|mingw/ =~ RUBY_PLATFORM Dir.mktmpdir do |tmpdir| |