diff options
author | Benoit Daloze <eregontp@gmail.com> | 2021-07-28 12:00:33 +0200 |
---|---|---|
committer | git <svn-admin@ruby-lang.org> | 2022-05-12 18:19:17 +0900 |
commit | 40ca208a6db8d3a53cc016caab2aa8301bafdac2 (patch) | |
tree | 88e7b92860030e397fc9539778566ba77748c6ad /test/uri/test_common.rb | |
parent | fbebfe1697938a684f460cd28af36cf1f056513c (diff) | |
download | ruby-40ca208a6db8d3a53cc016caab2aa8301bafdac2.tar.gz |
[ruby/uri] Improve URI.register_scheme tests and automatically upcase the given scheme
* Also add docs and mention current limitations.
* For reference, https://stackoverflow.com/a/3641782/388803 mentions the
valid characters in schemes.
https://github.com/ruby/uri/commit/4346daac75
Diffstat (limited to 'test/uri/test_common.rb')
-rw-r--r-- | test/uri/test_common.rb | 40 |
1 files changed, 37 insertions, 3 deletions
diff --git a/test/uri/test_common.rb b/test/uri/test_common.rb index 8cb23fe167..038f483a83 100644 --- a/test/uri/test_common.rb +++ b/test/uri/test_common.rb @@ -41,18 +41,52 @@ class TestCommon < Test::Unit::TestCase RUBY end + DEFAULT_SCHEMES = ["FILE", "FTP", "HTTP", "HTTPS", "LDAP", "LDAPS", "MAILTO", "WS", "WSS"].sort.freeze + def test_register_scheme - assert_equal(["FILE", "FTP", "HTTP", "HTTPS", "LDAP", "LDAPS", "MAILTO", "WS", "WSS"].sort, URI.scheme_list.keys.sort) + assert_equal(DEFAULT_SCHEMES, URI.scheme_list.keys.sort) foobar = Class.new(URI::Generic) URI.register_scheme 'FOOBAR', foobar begin - assert_equal(["FILE", "FTP", "HTTP", "HTTPS", "LDAP", "LDAPS", "MAILTO", "WS", "WSS", "FOOBAR"].sort, URI.scheme_list.keys.sort) + assert_include(URI.scheme_list.keys, "FOOBAR") + assert_equal foobar, URI.parse('foobar://localhost').class ensure URI.const_get(:Schemes).send(:remove_const, :FOOBAR) end - assert_equal(["FILE", "FTP", "HTTP", "HTTPS", "LDAP", "LDAPS", "MAILTO", "WS", "WSS"].sort, URI.scheme_list.keys.sort) + assert_equal(DEFAULT_SCHEMES, URI.scheme_list.keys.sort) + end + + def test_register_scheme_lowercase + assert_equal(DEFAULT_SCHEMES, URI.scheme_list.keys.sort) + + foobar = Class.new(URI::Generic) + URI.register_scheme 'foobarlower', foobar + begin + assert_include(URI.scheme_list.keys, "FOOBARLOWER") + assert_equal foobar, URI.parse('foobarlower://localhost').class + ensure + URI.const_get(:Schemes).send(:remove_const, :FOOBARLOWER) + end + + assert_equal(DEFAULT_SCHEMES, URI.scheme_list.keys.sort) + end + + def test_register_scheme_with_symbols + # Valid schemes from https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml + some_uri_class = Class.new(URI::Generic) + assert_raise(NameError) { URI.register_scheme 'ms-search', some_uri_class } + assert_raise(NameError) { URI.register_scheme 'microsoft.windows.camera', some_uri_class } + assert_raise(NameError) { URI.register_scheme 'coaps+ws', some_uri_class } + + ms_search_class = Class.new(URI::Generic) + URI.register_scheme 'MS_SEARCH', ms_search_class + begin + assert_equal URI::Generic, URI.parse('ms-search://localhost').class + ensure + URI.const_get(:Schemes).send(:remove_const, :MS_SEARCH) + end end def test_regexp |