Fix various autoload race conditions. (#5898)

* Add RUBY_VM_CRITICAL_SECTION for detecting unexpected context switch.

* Prevent race between GC mark and autoload setup.

* Protect race on autoload state.

* Avoid potential race condition when allocating `autoload_featuremap`.

* Add NEWS entry for autoload fixes.

1 files changed, 4 insertions, 0 deletions

diff --git a/thread.c b/thread.c
index aeb1a6308d..7582849767 100644
--- a/thread.c
+++ b/thread.c
@@ -1562,6 +1562,10 @@ static inline int
 blocking_region_begin(rb_thread_t *th, struct rb_blocking_region_buffer *region,
 		      rb_unblock_function_t *ubf, void *arg, int fail_if_interrupted)
 {
+#ifdef RUBY_VM_CRITICAL_SECTION
+    VM_ASSERT(rb_vm_critical_section_entered == 0);
+#endif
+
     region->prev_status = th->status;
     if (unblock_function_set(th, ubf, arg, fail_if_interrupted)) {
 	th->blocking_region_buffer = region;