diff options
| author | John Hawthorn <john@hawthorn.email> | 2023-04-18 07:09:16 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-04-18 10:09:16 -0400 |
| commit | 2dff1d4fdabd0fafeeac675baaaf7b06bb3150f9 (patch) | |
| tree | 222beb26cb8855103700fe880ccf32e518f3f89e /yjit.c | |
| parent | d8a6db7292e8c92540f3dd2c939508ca1dd8cc41 (diff) | |
| download | ruby-2dff1d4fdabd0fafeeac675baaaf7b06bb3150f9.tar.gz | |
YJIT: Fix raw sample stack lengths in exit traces (#7728)
yjit-trace-exits appends a synthetic sample for the instruction being
exited, but we didn't increment the size of the stack. Fixing this count
correctly lets us successfully generate a flamegraph from the exits.
I also replaced the line number for instructions with 0, as I don't
think the previous value had meaning.
Co-authored-by: Adam Hess <HParker@github.com>
Diffstat (limited to 'yjit.c')
| -rw-r--r-- | yjit.c | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -186,8 +186,9 @@ rb_yjit_exit_locations_dict(VALUE *yjit_raw_samples, int *yjit_line_samples, int int line_num = (int)yjit_line_samples[idx]; idx++; - rb_ary_push(raw_samples, SIZET2NUM(num)); - rb_ary_push(line_samples, INT2NUM(line_num)); + // + 1 as we append an additional sample for the insn + rb_ary_push(raw_samples, SIZET2NUM(num + 1)); + rb_ary_push(line_samples, INT2NUM(line_num + 1)); // Loop through the length of samples_len and add data to the // frames hash. Also push the current value onto the raw_samples |