diff options
| author | Yuki Okushi <huyuumi.dev+love@gmail.com> | 2023-01-11 14:18:58 +0900 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-01-11 14:18:58 +0900 |
| commit | 2c946bc303d3a3cbc8f3eb17976dc94d9e4c71a7 (patch) | |
| tree | e964c8db9c2800bc119fcc6c46f3e1d8935638e8 | |
| parent | c2d1cac36bba4f10071f9a5baddefb5925374a9a (diff) | |
| parent | 2214c6d194d668efe6b1ee000a150372110c114b (diff) | |
| download | rust-2c946bc303d3a3cbc8f3eb17976dc94d9e4c71a7.tar.gz | |
Rollup merge of #106689 - GuillaumeGomez:rustdoc-gui-files-array, r=notriddle
Fix invalid files array re-creation in rustdoc-gui tester
It fixes the error <code>expected `runTest` first argument to be a string</code>:
```
{
file_name: {
file_name: '/home/imperio/rust/rust/src/test/rustdoc-gui/type-declation-overflow.goml',
output: 'type-declation-overflow... FAILED\n' +
'...'
},
output: Error: expected `runTest` first argument to be a string
at runTest (/home/imperio/rust/rust/node_modules/browser-ui-test/src/index.js:591:15)
at runTests (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:144:26)
at main (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:278:15)
} Error: expected `runTest` first argument to be a string
at runTest (/home/imperio/rust/rust/node_modules/browser-ui-test/src/index.js:591:15)
at runTests (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:144:26)
at main (/home/imperio/rust/rust/src/tools/rustdoc-gui/tester.js:278:15)
```
The problem was that I concatenated two arrays of object whereas `files` is supposed to be an array of string.
r? `@notriddle`
| -rw-r--r-- | src/tools/rustdoc-gui/tester.js | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/tools/rustdoc-gui/tester.js b/src/tools/rustdoc-gui/tester.js index 900ca389436..554b2f81fa3 100644 --- a/src/tools/rustdoc-gui/tester.js +++ b/src/tools/rustdoc-gui/tester.js @@ -278,7 +278,8 @@ async function main(argv) { await runTests(opts, framework_options, files, new_results, status_bar, it + 1 >= NB_RETRY); Array.prototype.push.apply(results.successful, new_results.successful); // We generate the new list of files with the previously failing tests. - files = Array.prototype.concat(new_results.failed, new_results.errored); + files = Array.prototype.concat(new_results.failed, new_results.errored).map( + f => f['file_name']); if (files.length > originalFilesLen / 2) { // If we have too many failing tests, it's very likely not flaky failures anymore so // no need to retry. |