diff options
author | Guillaume Gomez <guillaume1.gomez@gmail.com> | 2023-02-19 14:47:56 +0100 |
---|---|---|
committer | GitHub <noreply@github.com> | 2023-02-19 14:47:56 +0100 |
commit | 243dcd0083c6cfb5f6ead85315bd16e5844e6c86 (patch) | |
tree | 92fea5ffe4a52fea9905a8dbf55a9475dce8e32a /tests/rustdoc-js-std/parser-errors.js | |
parent | bd63edc07aad0c3fa7300505cf45bacb6bfb650f (diff) | |
parent | 6209e6c5983f93526da54db1b66beb3f1d658437 (diff) | |
download | rust-243dcd0083c6cfb5f6ead85315bd16e5844e6c86.tar.gz |
Rollup merge of #108188 - jyn514:ra-sysroot, r=albertlarsan68
Change src/etc/vscode_settings.json to always treat ./library as the sysroot source
See
https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Frust-analyzer/topic/False.20error.20report.20for.20.60rust-analyzer.28private-field.29.60 for further discussion; previously this had various bugs.
I tested go-to-definition on:
- `use std::io::Write` in `src/bootstrap/setup.rs`
- `use std::cell::RefCell` in `src/librustdoc/core.rs`
- `use rustc_span::symbol::sym` in `src/librustdoc/core.rs`
- `use std::fmt` in `compiler/rustc_span/src/symbol.rs`
- `Global` in `library/alloc/src/alloc/tests.rs`
The following things still don't work:
- `Global.deallocate` in alloc/tests.rs. This function is under `cfg(not(test))`, so it can't be enabled without disabling RA in `tests.rs` altogether. I think this might be fixable by moving `library/alloc/src/alloc/tests.rs` to `library/alloc/tests/alloc/lib.rs`, so it's in a different crate, but I'd like to avoid blocking this improvement on that change.
cc `@thomcc` `@BoxyUwU` `@spastorino` - you've had issues with RA in the past, does this fix them? Are there any other use cases I should test? You can try these changes out by running `cp src/etc/vscode_settings.json .vscode/settings.json`, or running `x setup` and picking a random profile (it won't overwrite config.toml if it already exists). See https://github.com/rust-lang/rust/pull/108135 for plans to make updating the config easier.
r? `@Veykril`
Diffstat (limited to 'tests/rustdoc-js-std/parser-errors.js')
0 files changed, 0 insertions, 0 deletions