diff options
author | bors <bors@rust-lang.org> | 2023-04-13 04:03:10 +0000 |
---|---|---|
committer | bors <bors@rust-lang.org> | 2023-04-13 04:03:10 +0000 |
commit | a29dada983fa8d44f789d3a64408b7ad4f4c3487 (patch) | |
tree | 5a7ad7e72aee96c28151c76b87159595668ec73c /tests/rustdoc-js-std/parser-errors.js | |
parent | d8fc8192471063c7b72fb2f95f61a9427ab84b86 (diff) | |
parent | 171ccb54f06a168f10249b6cbfc22b1cb66ee125 (diff) | |
download | rust-a29dada983fa8d44f789d3a64408b7ad4f4c3487.tar.gz |
Auto merge of #108283 - the8472:remove-splice-into-pipe, r=ChrisDenton
don't splice from files into pipes in io::copy
This fixes potential data ordering issue where a write performed after a copy operation could become visible in the copy even though it signaled completion.
I assumed that by not setting `SPLICE_F_MOVE` we would be safe and the kernel would do a copy in kernel space and we could avoid the read-write syscall and copy-to/from-userspace costs. But apparently that flag only makes a difference when splicing from a pipe, but not when splicing into it.
Context: https://lkml.org/lkml/2023/2/9/673
Diffstat (limited to 'tests/rustdoc-js-std/parser-errors.js')
0 files changed, 0 insertions, 0 deletions