1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
|
//@run-rustfix
#![warn(clippy::needless_for_each)]
#![allow(unused)]
#![allow(
clippy::let_unit_value,
clippy::match_single_binding,
clippy::needless_return,
clippy::uninlined_format_args
)]
use std::collections::HashMap;
fn should_lint() {
let v: Vec<i32> = Vec::new();
let mut acc = 0;
for elem in v.iter() {
acc += elem;
}
for elem in v.into_iter() {
acc += elem;
}
for elem in [1, 2, 3].iter() {
acc += elem;
}
let mut hash_map: HashMap<i32, i32> = HashMap::new();
for (k, v) in hash_map.iter() {
acc += k + v;
}
for (k, v) in hash_map.iter_mut() {
acc += *k + *v;
}
for k in hash_map.keys() {
acc += k;
}
for v in hash_map.values() {
acc += v;
}
fn my_vec() -> Vec<i32> {
Vec::new()
}
for elem in my_vec().iter() {
acc += elem;
}
}
fn should_not_lint() {
let v: Vec<i32> = Vec::new();
let mut acc = 0;
// `for_each` argument is not closure.
fn print(x: &i32) {
println!("{}", x);
}
v.iter().for_each(print);
// User defined type.
struct MyStruct {
v: Vec<i32>,
}
impl MyStruct {
fn iter(&self) -> impl Iterator<Item = &i32> {
self.v.iter()
}
}
let s = MyStruct { v: Vec::new() };
s.iter().for_each(|elem| {
acc += elem;
});
// `for_each` follows long iterator chain.
v.iter().chain(v.iter()).for_each(|v| {
acc += v;
});
v.as_slice().iter().for_each(|v| {
acc += v;
});
s.v.iter().for_each(|v| {
acc += v;
});
// `return` is used in `Loop` of the closure.
v.iter().for_each(|v| {
for i in 0..*v {
if i == 10 {
return;
} else {
println!("{}", v);
}
}
if *v == 20 {
return;
} else {
println!("{}", v);
}
});
// Previously transformed iterator variable.
let it = v.iter();
it.chain(v.iter()).for_each(|elem| {
acc += elem;
});
// `for_each` is not directly in a statement.
match 1 {
_ => v.iter().for_each(|elem| {
acc += elem;
}),
}
// `for_each` is in a let bingind.
let _ = v.iter().for_each(|elem| {
acc += elem;
});
}
fn main() {}
|
