summaryrefslogtreecommitdiff
path: root/SCons/Taskmaster/Job.py
blob: a63b5291bbe6061bda0c93edae79dd0b186c83e7 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
# MIT License
#
# Copyright The SCons Foundation
#
# Permission is hereby granted, free of charge, to any person obtaining
# a copy of this software and associated documentation files (the
# "Software"), to deal in the Software without restriction, including
# without limitation the rights to use, copy, modify, merge, publish,
# distribute, sublicense, and/or sell copies of the Software, and to
# permit persons to whom the Software is furnished to do so, subject to
# the following conditions:
#
# The above copyright notice and this permission notice shall be included
# in all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY
# KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE
# WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
# NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
# LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
# OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
# WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

"""Serial and Parallel classes to execute build tasks.

The Jobs class provides a higher level interface to start,
stop, and wait on jobs.
"""

import SCons.compat

import logging
import os
import signal
import sys
import threading

from enum import Enum

import SCons.Errors
import SCons.Warnings


# The default stack size (in kilobytes) of the threads used to execute
# jobs in parallel.
#
# We use a stack size of 256 kilobytes. The default on some platforms
# is too large and prevents us from creating enough threads to fully
# parallelized the build. For example, the default stack size on linux
# is 8 MBytes.

explicit_stack_size = None
default_stack_size = 256

interrupt_msg = 'Build interrupted.'

class InterruptState:
    def __init__(self):
        self.interrupted = False

    def set(self):
        self.interrupted = True

    def __call__(self):
        return self.interrupted


class Jobs:
    """An instance of this class initializes N jobs, and provides
    methods for starting, stopping, and waiting on all N jobs.
    """

    def __init__(self, num, taskmaster):
        """
        Create 'num' jobs using the given taskmaster.

        If 'num' is 1 or less, then a serial job will be used,
        otherwise a parallel job with 'num' worker threads will
        be used.

        The 'num_jobs' attribute will be set to the actual number of jobs
        allocated.  If more than one job is requested but the Parallel
        class can't do it, it gets reset to 1.  Wrapping interfaces that
        care should check the value of 'num_jobs' after initialization.
        """

        # Importing GetOption here instead of at top of file to avoid
        # circular imports
        # pylint: disable=import-outside-toplevel
        from SCons.Script import GetOption

        self.job = None
        if num > 1:
            stack_size = explicit_stack_size
            if stack_size is None:
                stack_size = default_stack_size

            try:
                experimental_option = GetOption('experimental')
                if 'tm_v2' in experimental_option:
                    self.job = NewParallel(taskmaster, num, stack_size)
                else:
                    self.job = LegacyParallel(taskmaster, num, stack_size)

                self.num_jobs = num
            except NameError:
                pass
        if self.job is None:
            self.job = Serial(taskmaster)
            self.num_jobs = 1

    def run(self, postfunc=lambda: None):
        """Run the jobs.

        postfunc() will be invoked after the jobs has run. It will be
        invoked even if the jobs are interrupted by a keyboard
        interrupt (well, in fact by a signal such as either SIGINT,
        SIGTERM or SIGHUP). The execution of postfunc() is protected
        against keyboard interrupts and is guaranteed to run to
        completion."""
        self._setup_sig_handler()
        try:
            self.job.start()
        finally:
            postfunc()
            self._reset_sig_handler()

    def were_interrupted(self):
        """Returns whether the jobs were interrupted by a signal."""
        return self.job.interrupted()

    def _setup_sig_handler(self):
        """Setup an interrupt handler so that SCons can shutdown cleanly in
        various conditions:

          a) SIGINT: Keyboard interrupt
          b) SIGTERM: kill or system shutdown
          c) SIGHUP: Controlling shell exiting

        We handle all of these cases by stopping the taskmaster. It
        turns out that it's very difficult to stop the build process
        by throwing asynchronously an exception such as
        KeyboardInterrupt. For example, the python Condition
        variables (threading.Condition) and queues do not seem to be
        asynchronous-exception-safe. It would require adding a whole
        bunch of try/finally block and except KeyboardInterrupt all
        over the place.

        Note also that we have to be careful to handle the case when
        SCons forks before executing another process. In that case, we
        want the child to exit immediately.
        """
        def handler(signum, stack, self=self, parentpid=os.getpid()):
            if os.getpid() == parentpid:
                self.job.taskmaster.stop()
                self.job.interrupted.set()
            else:
                os._exit(2)  # pylint: disable=protected-access

        self.old_sigint = signal.signal(signal.SIGINT, handler)
        self.old_sigterm = signal.signal(signal.SIGTERM, handler)
        try:
            self.old_sighup = signal.signal(signal.SIGHUP, handler)
        except AttributeError:
            pass
        if (self.old_sigint is None) or (self.old_sigterm is None) or \
                (hasattr(self, "old_sighup") and self.old_sighup is None):
            msg = "Overwritting previous signal handler which was not installed from Python. " + \
                "Will not be able to reinstate and so will return to default handler."
            SCons.Warnings.warn(SCons.Warnings.SConsWarning, msg)

    def _reset_sig_handler(self):
        """Restore the signal handlers to their previous state (before the
         call to _setup_sig_handler()."""
        sigint_to_use = self.old_sigint if self.old_sigint is not None else signal.SIG_DFL
        sigterm_to_use = self.old_sigterm if self.old_sigterm is not None else signal.SIG_DFL
        signal.signal(signal.SIGINT, sigint_to_use)
        signal.signal(signal.SIGTERM, sigterm_to_use)
        try:
            sigterm_to_use = self.old_sighup if self.old_sighup is not None else signal.SIG_DFL
            signal.signal(signal.SIGHUP, sigterm_to_use)
        except AttributeError:
            pass


class Serial:
    """This class is used to execute tasks in series, and is more efficient
    than Parallel, but is only appropriate for non-parallel builds. Only
    one instance of this class should be in existence at a time.

    This class is not thread safe.
    """

    def __init__(self, taskmaster):
        """Create a new serial job given a taskmaster.

        The taskmaster's next_task() method should return the next task
        that needs to be executed, or None if there are no more tasks. The
        taskmaster's executed() method will be called for each task when it
        is successfully executed, or failed() will be called if it failed to
        execute (e.g. execute() raised an exception)."""

        self.taskmaster = taskmaster
        self.interrupted = InterruptState()

    def start(self):
        """Start the job. This will begin pulling tasks from the taskmaster
        and executing them, and return when there are no more tasks. If a task
        fails to execute (i.e. execute() raises an exception), then the job will
        stop."""

        while True:
            task = self.taskmaster.next_task()

            if task is None:
                break

            try:
                task.prepare()
                if task.needs_execute():
                    task.execute()
            except Exception:
                if self.interrupted():
                    try:
                        raise SCons.Errors.BuildError(
                            task.targets[0], errstr=interrupt_msg)
                    except Exception:
                        task.exception_set()
                else:
                    task.exception_set()

                # Let the failed() callback function arrange for the
                # build to stop if that's appropriate.
                task.failed()
            else:
                task.executed()

            task.postprocess()
        self.taskmaster.cleanup()


# Trap import failure so that everything in the Job module but the
# Parallel class (and its dependent classes) will work if the interpreter
# doesn't support threads.
try:
    import queue
    import threading
except ImportError:
    pass
else:
    class Worker(threading.Thread):
        """A worker thread waits on a task to be posted to its request queue,
        dequeues the task, executes it, and posts a tuple including the task
        and a boolean indicating whether the task executed successfully. """

        def __init__(self, requestQueue, resultsQueue, interrupted):
            super().__init__()
            self.daemon = True
            self.requestQueue = requestQueue
            self.resultsQueue = resultsQueue
            self.interrupted = interrupted
            self.start()

        def run(self):
            while True:
                task = self.requestQueue.get()

                if task is None:
                    # The "None" value is used as a sentinel by
                    # ThreadPool.cleanup().  This indicates that there
                    # are no more tasks, so we should quit.
                    break

                try:
                    if self.interrupted():
                        raise SCons.Errors.BuildError(
                            task.targets[0], errstr=interrupt_msg)
                    task.execute()
                except Exception:
                    task.exception_set()
                    ok = False
                else:
                    ok = True

                self.resultsQueue.put((task, ok))

    class ThreadPool:
        """This class is responsible for spawning and managing worker threads."""

        def __init__(self, num, stack_size, interrupted):
            """Create the request and reply queues, and 'num' worker threads.

            One must specify the stack size of the worker threads. The
            stack size is specified in kilobytes.
            """
            self.requestQueue = queue.Queue(0)
            self.resultsQueue = queue.Queue(0)

            try:
                prev_size = threading.stack_size(stack_size * 1024)
            except AttributeError as e:
                # Only print a warning if the stack size has been
                # explicitly set.
                if explicit_stack_size is not None:
                    msg = "Setting stack size is unsupported by this version of Python:\n    " + \
                        e.args[0]
                    SCons.Warnings.warn(SCons.Warnings.StackSizeWarning, msg)
            except ValueError as e:
                msg = "Setting stack size failed:\n    " + str(e)
                SCons.Warnings.warn(SCons.Warnings.StackSizeWarning, msg)

            # Create worker threads
            self.workers = []
            for _ in range(num):
                worker = Worker(self.requestQueue, self.resultsQueue, interrupted)
                self.workers.append(worker)

            if 'prev_size' in locals():
                threading.stack_size(prev_size)

        def put(self, task):
            """Put task into request queue."""
            self.requestQueue.put(task)

        def get(self):
            """Remove and return a result tuple from the results queue."""
            return self.resultsQueue.get()

        def preparation_failed(self, task):
            self.resultsQueue.put((task, False))

        def cleanup(self):
            """
            Shuts down the thread pool, giving each worker thread a
            chance to shut down gracefully.
            """
            # For each worker thread, put a sentinel "None" value
            # on the requestQueue (indicating that there's no work
            # to be done) so that each worker thread will get one and
            # terminate gracefully.
            for _ in self.workers:
                self.requestQueue.put(None)

            # Wait for all of the workers to terminate.
            #
            # If we don't do this, later Python versions (2.4, 2.5) often
            # seem to raise exceptions during shutdown.  This happens
            # in requestQueue.get(), as an assertion failure that
            # requestQueue.not_full is notified while not acquired,
            # seemingly because the main thread has shut down (or is
            # in the process of doing so) while the workers are still
            # trying to pull sentinels off the requestQueue.
            #
            # Normally these terminations should happen fairly quickly,
            # but we'll stick a one-second timeout on here just in case
            # someone gets hung.
            for worker in self.workers:
                worker.join(1.0)
            self.workers = []

    class LegacyParallel:
        """This class is used to execute tasks in parallel, and is somewhat
        less efficient than Serial, but is appropriate for parallel builds.

        This class is thread safe.
        """

        def __init__(self, taskmaster, num, stack_size):
            """Create a new parallel job given a taskmaster.

            The taskmaster's next_task() method should return the next
            task that needs to be executed, or None if there are no more
            tasks. The taskmaster's executed() method will be called
            for each task when it is successfully executed, or failed()
            will be called if the task failed to execute (i.e. execute()
            raised an exception).

            Note: calls to taskmaster are serialized, but calls to
            execute() on distinct tasks are not serialized, because
            that is the whole point of parallel jobs: they can execute
            multiple tasks simultaneously. """

            self.taskmaster = taskmaster
            self.interrupted = InterruptState()
            self.tp = ThreadPool(num, stack_size, self.interrupted)

            self.maxjobs = num

        def start(self):
            """Start the job. This will begin pulling tasks from the
            taskmaster and executing them, and return when there are no
            more tasks. If a task fails to execute (i.e. execute() raises
            an exception), then the job will stop."""

            jobs = 0

            while True:
                # Start up as many available tasks as we're
                # allowed to.
                while jobs < self.maxjobs:
                    task = self.taskmaster.next_task()
                    if task is None:
                        break

                    try:
                        # prepare task for execution
                        task.prepare()
                    except Exception:
                        task.exception_set()
                        task.failed()
                        task.postprocess()
                    else:
                        if task.needs_execute():
                            # dispatch task
                            self.tp.put(task)
                            jobs += 1
                        else:
                            task.executed()
                            task.postprocess()

                if not task and not jobs:
                    break

                # Let any/all completed tasks finish up before we go
                # back and put the next batch of tasks on the queue.
                while True:
                    task, ok = self.tp.get()
                    jobs -= 1

                    if ok:
                        task.executed()
                    else:
                        if self.interrupted():
                            try:
                                raise SCons.Errors.BuildError(
                                    task.targets[0], errstr=interrupt_msg)
                            except Exception:
                                task.exception_set()

                        # Let the failed() callback function arrange
                        # for the build to stop if that's appropriate.
                        task.failed()

                    task.postprocess()

                    if self.tp.resultsQueue.empty():
                        break

            self.tp.cleanup()
            self.taskmaster.cleanup()

    # An experimental new parallel scheduler that uses a leaders/followers pattern.
    class NewParallel:

        class State(Enum):
            READY = 0
            SEARCHING = 1
            STALLED = 2
            COMPLETED = 3

        class Worker(threading.Thread):
            def __init__(self, owner):
                super().__init__()
                self.daemon = True
                self.owner = owner
                self.start()

            def run(self):
                self.owner._work()

        def __init__(self, taskmaster, num, stack_size):
            self.taskmaster = taskmaster
            self.num_workers = num
            self.stack_size = stack_size
            self.interrupted = InterruptState()
            self.workers = []

            # The `tm_lock` is what ensures that we only have one
            # thread interacting with the taskmaster at a time. It
            # also protects access to our state that gets updated
            # concurrently. The `can_search_cv` is associated with
            # this mutex.
            self.tm_lock = threading.Lock()

            # Guarded under `tm_lock`.
            self.jobs = 0
            self.state = NewParallel.State.READY

            # The `can_search_cv` is used to manage a leader /
            # follower pattern for access to the taskmaster, and to
            # awaken from stalls.
            self.can_search_cv = threading.Condition(self.tm_lock)

            # The queue of tasks that have completed execution. The
            # next thread to obtain `tm_lock`` will retire them.
            self.results_queue_lock = threading.Lock()
            self.results_queue = []

            if self.taskmaster.trace:
                self.trace = self._setup_logging()
            else:
                self.trace = False

        def _setup_logging(self):
            jl = logging.getLogger("Job")
            jl.setLevel(level=logging.DEBUG)
            jl.addHandler(self.taskmaster.trace.log_handler)
            return jl

        def trace_message(self, message):
            # This grabs the name of the function which calls trace_message()
            method_name = sys._getframe(1).f_code.co_name + "():"
            thread_id=threading.get_ident()
            self.trace.debug('%s.%s [Thread:%s] %s' % (type(self).__name__, method_name, thread_id, message))
            # print('%-15s %s' % (method_name, message))

        def start(self):
            self._start_workers()
            for worker in self.workers:
                worker.join()
            self.workers = []
            self.taskmaster.cleanup()

        def _start_workers(self):
            prev_size = self._adjust_stack_size()
            for _ in range(self.num_workers):
                self.workers.append(NewParallel.Worker(self))
            self._restore_stack_size(prev_size)

        def _adjust_stack_size(self):
            try:
                prev_size = threading.stack_size(self.stack_size * 1024)
                return prev_size
            except AttributeError as e:
                # Only print a warning if the stack size has been
                # explicitly set.
                if explicit_stack_size is not None:
                    msg = "Setting stack size is unsupported by this version of Python:\n    " + \
                        e.args[0]
                    SCons.Warnings.warn(SCons.Warnings.StackSizeWarning, msg)
            except ValueError as e:
                msg = "Setting stack size failed:\n    " + str(e)
                SCons.Warnings.warn(SCons.Warnings.StackSizeWarning, msg)

            return None

        def _restore_stack_size(self, prev_size):
            if prev_size is not None:
                threading.stack_size(prev_size)

        def _work(self):

            task = None

            while True:

                # Obtain `tm_lock`, granting exclusive access to the taskmaster.
                with self.can_search_cv:

                    if self.trace:
                        self.trace_message("Gained exclusive access")

                    # Capture whether we got here with `task` set,
                    # then drop our reference to the task as we are no
                    # longer interested in the actual object.
                    completed_task = (task is not None)
                    task = None

                    # We will only have `completed_task` set here if
                    # we have looped back after executing a task. If
                    # we have completed a task and find that we are
                    # stalled, we should speculatively indicate that
                    # we are no longer stalled by transitioning to the
                    # 'ready' state which will bypass the condition
                    # wait so that we immediately process the results
                    # queue and hopefully light up new
                    # work. Otherwise, stay stalled, and we will wait
                    # in the condvar. Some other thread will come back
                    # here with a completed task.
                    if self.state == NewParallel.State.STALLED and completed_task:
                        if self.trace:
                            self.trace_message("Detected stall with completed task, bypassing wait")
                        self.state = NewParallel.State.READY

                    # Wait until we are neither searching nor stalled.
                    while self.state == NewParallel.State.SEARCHING or self.state == NewParallel.State.STALLED:
                        if self.trace:
                            self.trace_message("Search already in progress, waiting")
                        self.can_search_cv.wait()

                    # If someone set the completed flag, bail.
                    if self.state == NewParallel.State.COMPLETED:
                        if self.trace:
                            self.trace_message("Completion detected, breaking from main loop")
                        break

                    # Set the searching flag to indicate that a thread
                    # is currently in the critical section for
                    # taskmaster work.
                    #
                    if self.trace:
                        self.trace_message("Starting search")
                    self.state = NewParallel.State.SEARCHING

                    # Bulk acquire the tasks in the results queue
                    # under the result queue lock, then process them
                    # all outside that lock. We need to process the
                    # tasks in the results queue before looking for
                    # new work because we might be unable to find new
                    # work if we don't.
                    results_queue = []
                    with self.results_queue_lock:
                        results_queue, self.results_queue = self.results_queue, results_queue

                    if self.trace:
                        self.trace_message("Found {len(results_queue)} completed tasks to process")
                    for (rtask, rresult) in results_queue:
                        if rresult:
                            rtask.executed()
                        else:
                            if self.interrupted():
                                try:
                                    raise SCons.Errors.BuildError(
                                        rtask.targets[0], errstr=interrupt_msg)
                                except Exception:
                                    rtask.exception_set()

                            # Let the failed() callback function arrange
                            # for the build to stop if that's appropriate.
                            rtask.failed()

                        rtask.postprocess()
                        self.jobs -= 1

                    # We are done with any task objects that were in
                    # the results queue.
                    results_queue.clear()

                    # Now, turn the crank on the taskmaster until we
                    # either run out of tasks, or find a task that
                    # needs execution. If we run out of tasks, go idle
                    # until results arrive if jobs are pending, or
                    # mark the walk as complete if not.
                    while self.state == NewParallel.State.SEARCHING:
                        if self.trace:
                            self.trace_message("Searching for new tasks")
                        task = self.taskmaster.next_task()

                        if task:
                            # We found a task. Walk it through the
                            # task lifecycle. If it does not need
                            # execution, just complete the task and
                            # look for the next one. Otherwise,
                            # indicate that we are no longer searching
                            # so we can drop out of this loop, execute
                            # the task outside the lock, and allow
                            # another thread in to search.
                            try:
                                task.prepare()
                            except Exception:
                                task.exception_set()
                                task.failed()
                                task.postprocess()
                            else:
                                if not task.needs_execute():
                                    if self.trace:
                                        self.trace_message("Found internal task")
                                    task.executed()
                                    task.postprocess()
                                else:
                                    self.jobs += 1
                                    if self.trace:
                                        self.trace_message("Found task requiring execution")
                                    self.state = NewParallel.State.READY
                                    self.can_search_cv.notify()

                        else:
                            # We failed to find a task, so this thread
                            # cannot continue turning the taskmaster
                            # crank. We must exit the loop.
                            if self.jobs:
                                # No task was found, but there are
                                # outstanding jobs executing that
                                # might unblock new tasks when they
                                # complete. Transition to the stalled
                                # state. We do not need a notify,
                                # because we know there are threads
                                # outstanding that will re-enter the
                                # loop.
                                #
                                if self.trace:
                                    self.trace_message("Found no task requiring execution, but have jobs: marking stalled")
                                self.state = NewParallel.State.STALLED
                            else:
                                # We didn't find a task and there are
                                # no jobs outstanding, so there is
                                # nothing that will ever return
                                # results which might unblock new
                                # tasks. We can conclude that the walk
                                # is complete. Update our state to
                                # note completion and awaken anyone
                                # sleeping on the condvar.
                                #
                                if self.trace:
                                    self.trace_message("Found no task requiring execution, and have no jobs: marking complete")
                                self.state = NewParallel.State.COMPLETED
                                self.can_search_cv.notify_all()

                # We no longer hold `tm_lock` here. If we have a task,
                # we can now execute it. If there are threads waiting
                # to search, one of them can now begin turning the
                # taskmaster crank in NewParallel.
                if task:
                    if self.trace:
                        self.trace_message("Executing task")
                    ok = True
                    try:
                        if self.interrupted():
                            raise SCons.Errors.BuildError(
                                task.targets[0], errstr=interrupt_msg)
                        task.execute()
                    except Exception:
                        ok = False
                        task.exception_set()

                    # Grab the results queue lock and enqueue the
                    # executed task and state. The next thread into
                    # the searching loop will complete the
                    # postprocessing work under the taskmaster lock.
                    #
                    if self.trace:
                        self.trace_message("Enqueueing executed task results")
                    with self.results_queue_lock:
                        self.results_queue.append((task, ok))

                # Tricky state "fallthrough" here. We are going back
                # to the top of the loop, which behaves differently
                # depending on whether `task` is set. Do not perturb
                # the value of the `task` variable if you add new code
                # after this comment.

# Local Variables:
# tab-width:4
# indent-tabs-mode:nil
# End:
# vim: set expandtab tabstop=4 shiftwidth=4: