diff options
| author | Greg Noel <GregNoel@tigris.org> | 2010-03-27 07:39:52 +0000 |
|---|---|---|
| committer | Greg Noel <GregNoel@tigris.org> | 2010-03-27 07:39:52 +0000 |
| commit | eb7e67b1e6e7315a945edf79ebd2ec160ee85588 (patch) | |
| tree | fff879b4f9676a72e16c0f7b4dd969f050038b4f /test/Builder-factories.py | |
| parent | d5d9fceff1591065e13c1fcd283468fb0a288a36 (diff) | |
| download | scons-eb7e67b1e6e7315a945edf79ebd2ec160ee85588.tar.gz | |
http://scons.tigris.org/issues/show_bug.cgi?id=2329
Applied a number of idiomatic changes.
Uses of the 'sort()' method were converted into calls of 'sorted()' when
possible and the sorted() expression was inserted into a subsequent statement
whenever that made sense.
The statement 'while 1:' was changed to 'while True:'.
Names from the 'types' module (e.g., 'types.FooType') were converted to the
equivalent build-in type (e.g., 'foo').
Comparisons between types were changed to use 'isinstance()'.
Diffstat (limited to 'test/Builder-factories.py')
| -rw-r--r-- | test/Builder-factories.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/test/Builder-factories.py b/test/Builder-factories.py index fec90771..673920c8 100644 --- a/test/Builder-factories.py +++ b/test/Builder-factories.py @@ -48,9 +48,7 @@ MakeDirectory = Builder(action=mkdir, target_factory=Dir) def collect(env, source, target): out = open(str(target[0]), 'wb') dir = str(source[0]) - files = os.listdir(dir) - files.sort() - for f in files: + for f in sorted(os.listdir(dir)): f = os.path.join(dir, f) out.write(open(f, 'r').read()) out.close() |