http://scons.tigris.org/issues/show_bug.cgi?id=2329

Applied a number of idiomatic changes.

Uses of the 'sort()' method were converted into calls of 'sorted()' when
possible and the sorted() expression was inserted into a subsequent statement
whenever that made sense.

The statement 'while 1:' was changed to 'while True:'.

Names from the 'types' module (e.g., 'types.FooType') were converted to the
equivalent build-in type (e.g., 'foo').

Comparisons between types were changed to use 'isinstance()'.

1 files changed, 1 insertions, 2 deletions

diff --git a/timings/SCons_Bars.py b/timings/SCons_Bars.py
index 820d3ce6..2b677e94 100644
--- a/timings/SCons_Bars.py
+++ b/timings/SCons_Bars.py
@@ -42,8 +42,7 @@ class Bars(dict):
         if color is None:
             color = self.color
         if revs is None:
-            revs = self.keys()
-            revs.sort()
+            revs = sorted(self.keys())
         if labels:
             result = [ (r, color, None, self[r]) for r in revs ]
         else: