diff options
| author | Edward Rudd <urkle@outoforder.cc> | 2015-02-10 16:28:56 -0500 |
|---|---|---|
| committer | Edward Rudd <urkle@outoforder.cc> | 2015-02-10 16:28:56 -0500 |
| commit | 0d20694007d0ff5267d8c9068164a29e94260881 (patch) | |
| tree | ec0ea90f3303fa4ced0fea44a2b6ea6f75310aa1 | |
| parent | 064e4442aff22d0f6e5e41027caf29f85c8892df (diff) | |
| download | sdl-0d20694007d0ff5267d8c9068164a29e94260881.tar.gz | |
the last parameter of XChangeProperty is the number of elements.. and when the element format is 32.. the element is "long" so we have 5 long elements here.
Yes this seems confusing as on mac+linux Long is either 32 or 64bits depending on the architecture, but this is how the X11 protocol is defined. Thus 5 is the correct value for the nelts here. Not 5 or 10 depending on the architecture.
More info on the confusion https://bugs.freedesktop.org/show_bug.cgi?id=16802
| -rw-r--r-- | src/video/x11/SDL_x11window.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/video/x11/SDL_x11window.c b/src/video/x11/SDL_x11window.c index 05621e0ca..57148290c 100644 --- a/src/video/x11/SDL_x11window.c +++ b/src/video/x11/SDL_x11window.c @@ -333,7 +333,7 @@ SetWindowBordered(Display *display, int screen, Window window, SDL_bool border) X11_XChangeProperty(display, window, WM_HINTS, WM_HINTS, 32, PropModeReplace, (unsigned char *) &MWMHints, - sizeof(MWMHints) / 4); + sizeof(MWMHints) / sizeof(long)); } else { /* set the transient hints instead, if necessary */ X11_XSetTransientForHint(display, window, RootWindow(display, screen)); } |