summaryrefslogtreecommitdiff
path: root/sigc++/signal_base.h
diff options
context:
space:
mode:
authorKjell Ahlstedt <kjellahlstedt@gmail.com>2022-05-30 16:14:55 +0200
committerKjell Ahlstedt <kjellahlstedt@gmail.com>2022-05-30 16:14:55 +0200
commit8fb78907ccf3c4425d23ba1555f365f22d376685 (patch)
tree9f1a37b3ee1c3d7bd03af7e539cdaf3ad9313466 /sigc++/signal_base.h
parent8668c3f8e7e09a52d4f6b0c3a389799b2a98a904 (diff)
downloadsigc++-8fb78907ccf3c4425d23ba1555f365f22d376685.tar.gz
signal_with_accumulator derives from trackable
A slot made with signal_with_accumulator::make_slot() is then automatically disconnected when the signal is deleted, as in sigc++2. Fixes #80
Diffstat (limited to 'sigc++/signal_base.h')
-rw-r--r--sigc++/signal_base.h7
1 files changed, 4 insertions, 3 deletions
diff --git a/sigc++/signal_base.h b/sigc++/signal_base.h
index 8391782..a6da7d3 100644
--- a/sigc++/signal_base.h
+++ b/sigc++/signal_base.h
@@ -266,9 +266,10 @@ protected:
* @ref sigc::signal_with_accumulator::connect() "sigc::signal::connect()".
*/
-// TODO: When we can break ABI, let signal_base derive from trackable again.
-// It does in sigc++2. Otherwise the slot returned from signal::make_slot()
-// is not automatically disconnected when the signal is deleted.
+// TODO: When we can break ABI, let signal_base instead of signal_with_accumulator
+// derive from trackable, as in sigc++2. One of them must derive from trackable.
+// Otherwise the slot returned from signal_with_accumulator::make_slot() is not
+// automatically disconnected when the signal is deleted.
// https://github.com/libsigcplusplus/libsigcplusplus/issues/80
/** Base class for the @ref sigc::signal<T_return(T_arg...)> "sigc::signal" template.