diff options
author | Julian Kast <julian@livio.com> | 2021-09-30 14:02:46 -0400 |
---|---|---|
committer | Julian Kast <julian@livio.com> | 2021-09-30 14:02:46 -0400 |
commit | ed0591873c155e44f18cf60915447a010065f6d6 (patch) | |
tree | 6eb5f8e3bb963b9a6c787ca0f5e2073a83d344fb | |
parent | 0f9e1ce10e86d8ecf28398833dde5bd45522e8a9 (diff) | |
download | sdl_android-ed0591873c155e44f18cf60915447a010065f6d6.tar.gz |
code review suggestions
-rw-r--r-- | base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java b/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java index b732a525f..522c5c7e9 100644 --- a/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java +++ b/base/src/main/java/com/smartdevicelink/managers/file/DeleteFileOperation.java @@ -70,10 +70,12 @@ class DeleteFileOperation extends Task { if (getState() == Task.CANCELED) { return; } - if (!mutableRemoteFileNames.contains(fileName) && completionListener != null) { - String errorMessage = "File to delete is no longer on the head unit, aborting operation"; - // Returning BaseFileManager.SPACE_AVAILABLE_MAX_VALUE for bytesAvaialble as a placeHolder, it will not get updated in BaseFileManager as long as success returned is false. - completionListener.onComplete(false, BaseFileManager.SPACE_AVAILABLE_MAX_VALUE, mutableRemoteFileNames, errorMessage); + if (!mutableRemoteFileNames.contains(fileName)) { + if (completionListener != null) { + String errorMessage = "File to delete is no longer on the head unit, aborting operation"; + // Returning BaseFileManager.SPACE_AVAILABLE_MAX_VALUE for bytesAvaialble as a placeHolder, it will not get updated in BaseFileManager as long as success returned is false. + completionListener.onComplete(false, BaseFileManager.SPACE_AVAILABLE_MAX_VALUE, mutableRemoteFileNames, errorMessage); + } onFinished(); return; } |