diff options
author | Jacob Keeler <jacob.keeler@livioradio.com> | 2019-03-18 13:24:20 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2019-03-18 13:24:20 -0400 |
commit | 45c4441d7c3bab6d8d01866dd51ce393d093c265 (patch) | |
tree | 75bd0264260dfe1585a322dd1a636079f383c497 /.github | |
parent | a83066f7a9d243e3d7f839f86577b61867ef6e62 (diff) | |
parent | 9765ebf0ce1c2fd5fd841abf98c89d8fca3b7cd8 (diff) | |
download | sdl_core-45c4441d7c3bab6d8d01866dd51ce393d093c265.tar.gz |
Merge pull request #2724 from smartdevicelink/fix/issue_2720
pull_request_template.md - add best practices link and review information
Diffstat (limited to '.github')
-rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 83c3261f9b..301a22eafe 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,4 +1,4 @@ -[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_core/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA. +[Things to note: Pull Requests **must** fix an issue. Discussion about the feature / bug takes place in the issue, discussion of the implementation takes place in the PR. Please also see the [Contributing Guide](https://github.com/smartdevicelink/sdl_core/blob/master/.github/CONTRIBUTING.md) for information on branch naming and the CLA, and the [SmartDeviceLink GitHub Best Practices](https://d83tozu1c8tt6.cloudfront.net/media/resources/SDL_GitHub_BestPractices.pdf) document for more information on how to enter a pull request. Once this PR is ready for review, please request one from @theresalech. Delete the above section when you've read it.] @@ -30,4 +30,4 @@ This PR makes **[no / minor / major]** API changes. - [ ] [Task 2] ### CLA -- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform)
\ No newline at end of file +- [ ] I have signed [the CLA](https://docs.google.com/forms/d/e/1FAIpQLSdsgJY33VByaX482zHzi-xUm49JNnmuJOyAM6uegPQ2LXYVfA/viewform) |