summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShobhit Adlakha <adlakhashobhit@gmail.com>2019-02-21 12:53:56 -0500
committerShobhit Adlakha <adlakhashobhit@gmail.com>2019-02-21 12:53:56 -0500
commit590d68370d88d22fa788e83df00572a8bf368281 (patch)
treeb422413f94d20fd00cf7d7b653865d5f5434a22e
parent06708fcc992e6d2110e4c0e4bd77311c7e0cec40 (diff)
downloadsdl_core-feature/Getsystemcapability_Subscription.tar.gz
Addressed review comments and removed extra debug statementsfeature/Getsystemcapability_Subscription
-rw-r--r--src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/extensions/system_capability_app_extension.h2
-rw-r--r--src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/get_system_capability_request.cc7
-rw-r--r--src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_capability_updated_notification.cc2
-rw-r--r--src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/extensions/system_capability_app_extension.cc3
4 files changed, 5 insertions, 9 deletions
diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/extensions/system_capability_app_extension.h b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/extensions/system_capability_app_extension.h
index 833cf5e214..fb82cf37c2 100644
--- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/extensions/system_capability_app_extension.h
+++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/include/sdl_rpc_plugin/extensions/system_capability_app_extension.h
@@ -68,7 +68,7 @@ class SystemCapabilityAppExtension : public app_mngr_::AppExtension {
void ProcessResumption(
const smart_objects::SmartObject& resumption_data) OVERRIDE;
- static unsigned SystemCapabilityAppExtensionUID;
+ static const app_mngr_::AppExtensionUID SystemCapabilityAppExtensionUID;
static SystemCapabilityAppExtension& ExtractExtension(
app_mngr_::Application& app);
diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/get_system_capability_request.cc b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/get_system_capability_request.cc
index e5074a3e46..1449f0e061 100644
--- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/get_system_capability_request.cc
+++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/get_system_capability_request.cc
@@ -151,7 +151,6 @@ void GetSystemCapabilityRequest::Run() {
[strings::app_services_capabilities] =
app_service_capabilities;
- MessageHelper::PrintSmartObject(response_params);
break;
}
default: // Return unsupported resource
@@ -165,13 +164,11 @@ void GetSystemCapabilityRequest::Run() {
if ((*message_)[app_mngr::strings::msg_params][strings::subscribe]
.asBool() == true) {
LOG4CXX_DEBUG(logger_,
- "GETSYSCAP: Subscribe to system capability - "
- << response_type);
+ "Subscribe to system capability: " << response_type);
ext.SubscribeTo(response_type);
} else {
LOG4CXX_DEBUG(logger_,
- "GETSYSCAP: Unsubscribe from system capability - "
- << response_type);
+ "Unsubscribe from system capability: " << response_type);
ext.UnsubscribeFrom(response_type);
}
}
diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_capability_updated_notification.cc b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_capability_updated_notification.cc
index 079e59eed1..6a1f0844d9 100644
--- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_capability_updated_notification.cc
+++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/commands/mobile/on_system_capability_updated_notification.cc
@@ -56,8 +56,6 @@ void OnSystemCapabilityUpdatedNotification::Run() {
for (; applications.end() != app_it; ++app_it) {
const ApplicationSharedPtr app = *app_it;
- LOG4CXX_DEBUG(logger_,
- "ONSYSCAP: Send OnSystemCapabilityUpdatedNotification");
LOG4CXX_INFO(logger_,
"Sending OnSystemCapabilityUpdated " << capability_type_string
<< " application id "
diff --git a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/extensions/system_capability_app_extension.cc b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/extensions/system_capability_app_extension.cc
index 2178738013..130585a927 100644
--- a/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/extensions/system_capability_app_extension.cc
+++ b/src/components/application_manager/rpc_plugins/sdl_rpc_plugin/src/extensions/system_capability_app_extension.cc
@@ -4,7 +4,8 @@ namespace sdl_rpc_plugin {
CREATE_LOGGERPTR_GLOBAL(logger_, "GetSystemCapabilitiesAppExtension")
namespace app_mngr_ = application_manager;
-unsigned SystemCapabilityAppExtension::SystemCapabilityAppExtensionUID = 200;
+const app_mngr_::AppExtensionUID
+ SystemCapabilityAppExtension::SystemCapabilityAppExtensionUID = 200;
SystemCapabilityAppExtension::SystemCapabilityAppExtension(
sdl_rpc_plugin::SDLRPCPlugin& plugin, app_mngr_::Application& app)