summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShobhit Adlakha <adlakhashobhit@gmail.com>2019-03-07 19:56:51 -0500
committerShobhit Adlakha <adlakhashobhit@gmail.com>2019-03-07 19:56:51 -0500
commit3cb709e6a029a76b3b37b213cf523f3671a3d1c6 (patch)
tree2a1f38d3987e6c9959cd0cd3f0b91d80cb62813c
parentd255c6004c831f4b208c1cec086a7088dafa7196 (diff)
downloadsdl_core-feature/handle_unknown_rpc_params.tar.gz
Fixed rpc_passing_handler_ initializer and added commentsfeature/handle_unknown_rpc_params
-rw-r--r--src/components/application_manager/src/app_service_manager.cc2
-rw-r--r--src/components/application_manager/src/rpc_passing_handler.cc3
2 files changed, 4 insertions, 1 deletions
diff --git a/src/components/application_manager/src/app_service_manager.cc b/src/components/application_manager/src/app_service_manager.cc
index 06e91a8c2f..d148e4ef61 100644
--- a/src/components/application_manager/src/app_service_manager.cc
+++ b/src/components/application_manager/src/app_service_manager.cc
@@ -56,7 +56,7 @@ AppServiceManager::AppServiceManager(ApplicationManager& app_manager,
resumption::LastState& last_state)
: app_manager_(app_manager)
, last_state_(last_state)
- , rpc_passing_handler_{*this, app_manager_} {}
+ , rpc_passing_handler_(*this, app_manager_) {}
AppServiceManager::~AppServiceManager() {
LOG4CXX_AUTO_TRACE(logger_);
diff --git a/src/components/application_manager/src/rpc_passing_handler.cc b/src/components/application_manager/src/rpc_passing_handler.cc
index 35caf5a15c..058c5269e4 100644
--- a/src/components/application_manager/src/rpc_passing_handler.cc
+++ b/src/components/application_manager/src/rpc_passing_handler.cc
@@ -68,6 +68,8 @@ bool RPCPassingHandler::IsPassThroughMessage(
if (rpc_request_queue.find(correlation_id) != rpc_request_queue.end()) {
if (message_type == MessageType::kResponse &&
source == commands::Command::CommandSource::SOURCE_SDL) {
+ // Checks if response is being sent to mobile then removes the correlation
+ // id from the map
rpc_request_queue.erase(correlation_id);
}
return true;
@@ -101,6 +103,7 @@ bool RPCPassingHandler::RPCPassThrough(smart_objects::SmartObject rpc_message) {
LOG4CXX_DEBUG(logger_, "RPC_PASSING: ");
MessageHelper::PrintSmartObject(rpc_message);
+ // Clear timers for timed out requests
ClearCompletedTimers();
switch (message_type) {
case MessageType::kRequest: {