diff options
| author | jacobkeeler <jacob.keeler@livioradio.com> | 2020-09-17 14:41:27 -0400 |
|---|---|---|
| committer | jacobkeeler <jacob.keeler@livioradio.com> | 2020-09-17 14:41:27 -0400 |
| commit | 68aa6ad1b2aa0419a73538de8717a23e41c0e1a7 (patch) | |
| tree | 146d89a75b05c12b87c2a3aa9a8efb8e0167883c | |
| parent | 1f52a0ef360475ba268c49e1eec8b0a93050f132 (diff) | |
| download | sdl_core-fix/coverity_7.0.tar.gz | |
Add fixes for new Coverity issuesfix/coverity_7.0
Fixes CID 214309, 214305, 214304
3 files changed, 8 insertions, 2 deletions
diff --git a/src/components/application_manager/include/application_manager/resumption/resumption_data_processor.h b/src/components/application_manager/include/application_manager/resumption/resumption_data_processor.h index 60e2e5d1a4..3f55b02ed3 100644 --- a/src/components/application_manager/include/application_manager/resumption/resumption_data_processor.h +++ b/src/components/application_manager/include/application_manager/resumption/resumption_data_processor.h @@ -74,6 +74,11 @@ struct ResumptionRequest { class ResumptionDataProcessor { public: /** + * @brief ResumptionDataProcessor class destructor + */ + virtual ~ResumptionDataProcessor() {} + + /** * @brief Running resumption data process from saved_app to application. * @param application application which will be resumed * @param saved_app application specific section from backup file diff --git a/src/components/application_manager/src/resumption/resumption_data_processor_impl.cc b/src/components/application_manager/src/resumption/resumption_data_processor_impl.cc index c067167041..a490429197 100644 --- a/src/components/application_manager/src/resumption/resumption_data_processor_impl.cc +++ b/src/components/application_manager/src/resumption/resumption_data_processor_impl.cc @@ -1015,7 +1015,7 @@ void ResumptionDataProcessorImpl::DeletePluginsSubscriptions( if (!status.successful_module_subscriptions_.empty()) { extension_modules_subscriptions[message_params::kModuleData] = - new smart_objects::SmartObject(smart_objects::SmartType_Array); + smart_objects::SmartObject(smart_objects::SmartType_Array); auto& module_data_so = extension_modules_subscriptions[message_params::kModuleData]; @@ -1023,7 +1023,7 @@ void ResumptionDataProcessorImpl::DeletePluginsSubscriptions( uint32_t index = 0; for (const auto& module : status.successful_module_subscriptions_) { module_data_so[index] = - new smart_objects::SmartObject(smart_objects::SmartType_Map); + smart_objects::SmartObject(smart_objects::SmartType_Map); module_data_so[index][message_params::kModuleType] = module.first; module_data_so[index][message_params::kModuleId] = module.second; index++; diff --git a/src/components/include/utils/ilogger.h b/src/components/include/utils/ilogger.h index ba2f93df9b..3cf4777391 100644 --- a/src/components/include/utils/ilogger.h +++ b/src/components/include/utils/ilogger.h @@ -76,6 +76,7 @@ class Logger { class ThirdPartyLoggerInterface { public: + virtual ~ThirdPartyLoggerInterface() {} virtual void Init() = 0; virtual void DeInit() = 0; virtual bool IsEnabledFor(const std::string& component, |