summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJackLivio <jack@livio.io>2019-04-04 10:12:30 -0400
committerJackLivio <jack@livio.io>2019-04-04 10:12:30 -0400
commitbd44f393d9c098b4887e20e52ff8c0dec07afe57 (patch)
tree0884fa9100f9f19efce5312fca55ffbbfc467b4e
parentf84bb53084e44862af2ab8db9a55dd9f3eef48d8 (diff)
downloadsdl_core-fix/icon_url_double_response.tar.gz
Add clarifying commentfix/icon_url_double_response
-rw-r--r--src/components/application_manager/src/rpc_handler_impl.cc6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/components/application_manager/src/rpc_handler_impl.cc b/src/components/application_manager/src/rpc_handler_impl.cc
index 8719fa4da0..156abfbed8 100644
--- a/src/components/application_manager/src/rpc_handler_impl.cc
+++ b/src/components/application_manager/src/rpc_handler_impl.cc
@@ -80,8 +80,12 @@ void RPCHandlerImpl::ProcessMessageFromMobile(
std::shared_ptr<smart_objects::SmartObject> response(
MessageHelper::CreateNegativeResponse(message->connection_key(),
message->function_id(),
- message->correlation_id(),
+ 0,
mobile_apis::Result::INVALID_ID));
+ // CreateNegativeResponse() takes a uint32_t for correlation_id, therefore a
+ // negative number cannot be passed to that function or else it will be
+ // improperly cast. correlation_id is reassigned below to its original
+ // value.
(*response)[strings::params][strings::correlation_id] =
message->correlation_id();
(*response)[strings::msg_params][strings::info] =